Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component refactor and loading indicator stub #11

Merged
merged 18 commits into from
Jun 13, 2019
Merged

Component refactor and loading indicator stub #11

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
44a3579
Adds localization for pwa script
vdwijngaert Jun 8, 2019
74b94b6
Moves PWA page content to a single root component
vdwijngaert Jun 8, 2019
65b8466
Refactures component and api logic, adds loading indicator stub
vdwijngaert Jun 8, 2019
7e847e8
production build for pwa-page.js
vdwijngaert Jun 8, 2019
5ed7d84
Only show loading indicator when list is empty.
vdwijngaert Jun 8, 2019
10aa23c
Use wp_add_inline_script and move config to root state
vdwijngaert Jun 13, 2019
ea777b6
Documentation for interval time
vdwijngaert Jun 13, 2019
1246eeb
Merge remote-tracking branch 'origin/loading-indicator' into loading-…
vdwijngaert Jun 13, 2019
b7632b3
Rename updateInterval
vdwijngaert Jun 13, 2019
6452be0
Added jsdoc documentation for custom functions/methods
vdwijngaert Jun 13, 2019
601abc5
Named export for Page component
vdwijngaert Jun 13, 2019
899b9cf
Improved readability in schedule component
vdwijngaert Jun 13, 2019
17614fb
Improved readability for SessionsGroup component
vdwijngaert Jun 13, 2019
4c44bf6
Merge branch 'master' into loading-indicator
vdwijngaert Jun 13, 2019
bcd7f7f
Provided fallbacks for when there are no more "up next" sessions
vdwijngaert Jun 13, 2019
0e84c0f
fixed check for categories.length
vdwijngaert Jun 13, 2019
88599f8
Production build of pwa-page.js.
vdwijngaert Jun 13, 2019
0a6cdeb
Improved readability for entity fetching logic
vdwijngaert Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion includes/page-templates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function enqueue_assets() {
return;
}

wp_enqueue_script(
wp_register_script(
'wordcamp-pwa-page',
WCPWAP_PLUGIN_URL . '/dist/pwa-page.js',
file_exists( WCPWAP_PLUGIN_PATH . '/dist/pwa-page.deps.json' ) ?
Expand All @@ -71,6 +71,15 @@ function enqueue_assets() {
true
);

wp_localize_script( 'wordcamp-pwa-page', 'WCPWAP', [
vdwijngaert marked this conversation as resolved.
Show resolved Hide resolved
'urls' => [
'schedule' => esc_url( site_url( __( 'schedule', 'wordcamp-pwa-page' ) ) ),
'posts' => esc_url( get_post_type_archive_link( 'post' ) ),
]
] );

wp_enqueue_script( 'wordcamp-pwa-page' );
vdwijngaert marked this conversation as resolved.
Show resolved Hide resolved

wp_enqueue_style(
'wordcamp-pwa-page',
WCPWAP_PLUGIN_URL . '/templates/assets/pwa-page.css',
Expand Down