-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component refactor and loading indicator stub #11
Conversation
Signed-off-by: Koen Van den Wijngaert <[email protected]>
Signed-off-by: Koen Van den Wijngaert <[email protected]>
Signed-off-by: Koen Van den Wijngaert <[email protected]>
Signed-off-by: Koen Van den Wijngaert <[email protected]>
Note: it's my first time working with the WordPress implementation of React, hope I did okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me 👍
There are a few things I think would help improve it, if there's time.
/** | ||
* External dependencies | ||
*/ | ||
import { sortBy } from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the native sort()
function may be able to replace this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the original code (by @avillegasn ?). I haven't looked at the internals, maybe something to look into in the future.
Thanks for the insightful suggestions, @iandunn. Will try to implement these tonight and make sure everything merges. |
Co-Authored-By: Ian Dunn <[email protected]>
Aight, all suggestions are answered and/or implemented. Let's do this :) Note: I also made some changes to the session logic. In my test environment all sessions were concluded in 2014, so I got a lot of errors when enabling the production environment. Right now, most properties should have proper fallbacks. Now it displays "TRACK FINISHED" when there is no more session in the "up next" section. Now it shouldn't throw any errors, but we might want to change this to something more robust, or have some state for when all sessions are concluded. |
LGTM :) |
See #6 and #10.
Schedule
andLatestPosts
)