Add reference to timeout information in WebAuthn #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aymentConfirmationRequest dictionary
| @@ -623,7 +623,9 @@ members: | |||
|
|
|||
| : <dfn>timeout</dfn> member | |||
| :: The number of milliseconds before the request to sign the transaction | |||
| details times out. At most 1 hour. | |||
| details times out. At most 1 hour. Default values and the range of | |||
There was a problem hiding this comment.
This adds a normative requirement for At most 1 hour., which I don't think is there in WebAuthn? (Is it?)
|
Hi @stephenmcgruer, |
|
Whoops, completely missed that that sentence is pre-existing. We probably shouldn't have it (why is it there?), but that's ok, we can fix that sometime later. This CL LGTM. |
stephenmcgruer
approved these changes
Dec 13, 2023
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2023
SHA: bf81d4e Reason: push, by stephenmcgruer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2023
SHA: bf81d4e Reason: push, by stephenmcgruer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion about default values from SPC integration into MDN.
Preview | Diff