Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Secure Payment Confirmation #30439

Merged
merged 87 commits into from
Dec 1, 2023
Merged

Conversation

ianbjacobs
Copy link
Contributor

Description

This pull request supersedes pull request 28705 based on discussion for how best to structure the integration of Secure Payment Confirmation (SPC).

Motivation

SPC is already shipping in several browsers and should be documented on MDN.

Additional details

Related issues and pull requests

Relates to #421.

cc @wbamberg, @stephenmcgruer, @mountainhippo

@ianbjacobs ianbjacobs requested a review from a team as a code owner November 21, 2023 22:00
@ianbjacobs ianbjacobs requested review from wbamberg and removed request for a team November 21, 2023 22:00
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 21, 2023
@ianbjacobs
Copy link
Contributor Author

Hi @wbamberg! Here's my first pass at integrating as we discussed on #28705; I am sure edits will be needed and look forward to your review.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -34,11 +34,14 @@ Payment handlers are identified by **payment method identifiers**, which are str

### Standardized payment method identifiers

There is currently only one registered [standardized payment method identifier](https://www.w3.org/TR/payment-method-id/#registry) (more may be added in the future):
- `secure-payment-confirmation`
- : The [standardized payment method dentifier](https://www.w3.org/TR/payment-method-id/#registry)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- : The [standardized payment method dentifier](https://www.w3.org/TR/payment-method-id/#registry)
- : The [standardized payment method dentifier](https://www.w3.org/TR/payment-method-id/#registry)

There is currently only one registered [standardized payment method identifier](https://www.w3.org/TR/payment-method-id/#registry) (more may be added in the future):
- `secure-payment-confirmation`
- : The [standardized payment method dentifier](https://www.w3.org/TR/payment-method-id/#registry)
for [Secure Payment Confirmation](https://w3c.github.io/secure-payment-confirmation) is "secure-payment-confirmation". The Payment Request data for this payment is defined by the [SecurePaymentConfirmationRequest dictionary](/en-US/docs/Web/API/SecurePaymentConfirmationRequest). For more information see [Using Payment Request API for Secure Payment Confirmation](/en-US/docs/Web/API/Payment_Request_API/Using_with_Secure_Payment_Confirmation).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
for [Secure Payment Confirmation](https://w3c.github.io/secure-payment-confirmation) is "secure-payment-confirmation". The Payment Request data for this payment is defined by the [SecurePaymentConfirmationRequest dictionary](/en-US/docs/Web/API/SecurePaymentConfirmationRequest). For more information see [Using Payment Request API for Secure Payment Confirmation](/en-US/docs/Web/API/Payment_Request_API/Using_with_Secure_Payment_Confirmation).
for [Secure Payment Confirmation](https://w3c.github.io/secure-payment-confirmation) is "secure-payment-confirmation". The Payment Request data for this payment is defined by the [SecurePaymentConfirmationRequest dictionary](/en-US/docs/Web/API/SecurePaymentConfirmationRequest). For more information see [Using Payment Request API for Secure Payment Confirmation](/en-US/docs/Web/API/Payment_Request_API/Using_with_Secure_Payment_Confirmation).

files/en-us/web/api/payment_request_api/concepts/index.md Outdated Show resolved Hide resolved
Comment on lines 14 to 19
- `challenge`
- : A random [challenge](/en-US/docs/Web/API/CredentialsContainer/create#challenge) that the relying party generates on the server side
to prevent replay attacks.

- `rpId`
- : The [Relying Party Identifier](/en-US/docs/Web/API/CredentialsContainer/get#rpid) of the credentials.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `challenge`
- : A random [challenge](/en-US/docs/Web/API/CredentialsContainer/create#challenge) that the relying party generates on the server side
to prevent replay attacks.
- `rpId`
- : The [Relying Party Identifier](/en-US/docs/Web/API/CredentialsContainer/get#rpid) of the credentials.
- `challenge`
- : A random [challenge](/en-US/docs/Web/API/CredentialsContainer/create#challenge) that the relying party generates on the server side
to prevent replay attacks.

Comment on lines 21 to 22
- `credentialIds`
- : The list of credential identifiers for the given instrument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `credentialIds`
- : The list of credential identifiers for the given instrument.
- `rpId`
- : The [Relying Party Identifier](/en-US/docs/Web/API/CredentialsContainer/get#rpid) of the credentials.

Comment on lines 24 to 26
- `instrument`
- : The description of the instrument name and icon to display during
registration and to be signed along with the transaction details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `instrument`
- : The description of the instrument name and icon to display during
registration and to be signed along with the transaction details.
- `credentialIds`
- : The list of credential identifiers for the given instrument.

Comment on lines 28 to 30
- `timeout`
- : The number of milliseconds before the request to sign the transaction
details times out. At most 1 hour.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `timeout`
- : The number of milliseconds before the request to sign the transaction
details times out. At most 1 hour.
- `instrument`
- : The description of the instrument name and icon to display during
registration and to be signed along with the transaction details.

Comment on lines 32 to 35
- `payeeName`
- : The display name of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeOrigin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `payeeName`
- : The display name of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeOrigin.
- `timeout`
- : The number of milliseconds before the request to sign the transaction
details times out. At most 1 hour.

@@ -0,0 +1,63 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: ---]

files/en-us/web/api/payment_request_api/concepts/index.md Outdated Show resolved Hide resolved
Comment on lines 37 to 40
- `payeeOrigin`
- : The [=/origin=] of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeName.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `payeeOrigin`
- : The [=/origin=] of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeName.
- `payeeName`
- : The display name of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeOrigin.

Comment on lines 42 to 43
- `extensions`
- : Any [WebAuthn extensions](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions) that should be used for the passed credential(s). The caller does not need to specify the [payment extension](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions#payment); it is added automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `extensions`
- : Any [WebAuthn extensions](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions) that should be used for the passed credential(s). The caller does not need to specify the [payment extension](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions#payment); it is added automatically.
- `payeeOrigin`
- : The [=/origin=] of the payee that this SPC call is for (e.g., the
merchant). Optional, may be provided alongside or instead of
payeeName.

Comment on lines 45 to 48
- `locale`
- : An optional list of well-formed {{RFC(5646, "Tags for Identifying Languages (also known as BCP 47)")}} language tags, in descending
order of priority, that identify the local preferences of the
website, i.e. a language priority list {{RFC(4647, "Matching of Language Tags")}}, which the user agent can use to perform [language negotiation](/en-US/docs/Web/HTTP/Content_negotiation) and locale-affected formatting with the caller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `locale`
- : An optional list of well-formed {{RFC(5646, "Tags for Identifying Languages (also known as BCP 47)")}} language tags, in descending
order of priority, that identify the local preferences of the
website, i.e. a language priority list {{RFC(4647, "Matching of Language Tags")}}, which the user agent can use to perform [language negotiation](/en-US/docs/Web/HTTP/Content_negotiation) and locale-affected formatting with the caller.
- `extensions`
- : Any [WebAuthn extensions](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions) that should be used for the passed credential(s). The caller does not need to specify the [payment extension](/en-US/docs/Web/API/Web_Authentication_API/WebAuthn_extensions#payment); it is added automatically.

Comment on lines 50 to 54
NOTE: The locale is distinct from
language or direction metadata associated with specific input
members, in that it represents the caller's requested localized
experience rather than assertion about a specific string value.
See [SPC internationalization Considerations](https://w3c.github.io/secure-payment-confirmation/#sctn-i18n-considerations) for more discussion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
NOTE: The locale is distinct from
language or direction metadata associated with specific input
members, in that it represents the caller's requested localized
experience rather than assertion about a specific string value.
See [SPC internationalization Considerations](https://w3c.github.io/secure-payment-confirmation/#sctn-i18n-considerations) for more discussion.
- `locale`
- : An optional list of well-formed {{RFC(5646, "Tags for Identifying Languages (also known as BCP 47)")}} language tags, in descending
order of priority, that identify the local preferences of the
website, i.e. a language priority list {{RFC(4647, "Matching of Language Tags")}}, which the user agent can use to perform [language negotiation](/en-US/docs/Web/HTTP/Content_negotiation) and locale-affected formatting with the caller.

Comment on lines 56 to 58
- `showOptOut`
- : Whether the user should be given a chance to opt-out during the
[transaction confirmation UX](https://w3c.github.io/secure-payment-confirmation/#sctn-transaction-confirmation-ux). Optional, default false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
- `showOptOut`
- : Whether the user should be given a chance to opt-out during the
[transaction confirmation UX](https://w3c.github.io/secure-payment-confirmation/#sctn-transaction-confirmation-ux). Optional, default false.
NOTE: The locale is distinct from
language or direction metadata associated with specific input
members, in that it represents the caller's requested localized
experience rather than assertion about a specific string value.
See [SPC internationalization Considerations](https://w3c.github.io/secure-payment-confirmation/#sctn-i18n-considerations) for more discussion.

ianbjacobs and others added 4 commits November 21, 2023 18:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Secure Payment Confirmation (SPC), available through the Payment Request API, provides a mechanism for strong customer authentication during checkout, thereby protecting against online payment fraud.

To protect against online payment fraud, it is common to authenticate the account holder. Strong authentication lowers the risk of fraud, but increases the likelihood that friction during checkout will lead to shopping cart abandonment. Banks, merchants, payment services providers, and other entities in a payments ecosystem therefore consider a number of factors when deciding what type and strength of authentication to use for each transaction, including the amount, the items being purchased, the user's payment history, which party bears liability in the case of fraud, and regulatory requirements (such as [European Payment Services Directive 2](https://en.wikipedia.org/wiki/Payment_Services_Directive#Revised_Directive_on_Payment_Services_(PSD2)) requirements for strong customer authentication and evidence of user consent).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
To protect against online payment fraud, it is common to authenticate the account holder. Strong authentication lowers the risk of fraud, but increases the likelihood that friction during checkout will lead to shopping cart abandonment. Banks, merchants, payment services providers, and other entities in a payments ecosystem therefore consider a number of factors when deciding what type and strength of authentication to use for each transaction, including the amount, the items being purchased, the user's payment history, which party bears liability in the case of fraud, and regulatory requirements (such as [European Payment Services Directive 2](https://en.wikipedia.org/wiki/Payment_Services_Directive#Revised_Directive_on_Payment_Services_(PSD2)) requirements for strong customer authentication and evidence of user consent).
To protect against online payment fraud, it is common to authenticate the account holder. Strong authentication lowers the risk of fraud, but increases the likelihood that friction during checkout will lead to shopping cart abandonment. Banks, merchants, payment services providers, and other entities in a payments ecosystem therefore consider a number of factors when deciding what type and strength of authentication to use for each transaction, including the amount, the items being purchased, the user's payment history, which party bears liability in the case of fraud, and regulatory requirements (such as [European Payment Services Directive 2](<https://en.wikipedia.org/wiki/Payment_Services_Directive#Revised_Directive_on_Payment_Services_(PSD2)>) requirements for strong customer authentication and evidence of user consent).

ianbjacobs and others added 6 commits November 21, 2023 18:12
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…confirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ianbjacobs and others added 4 commits November 30, 2023 16:19
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Alphabetical order
* Data types provided
* {{optional_inline}} added
ianbjacobs and others added 2 commits November 30, 2023 16:50
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ianbjacobs
Copy link
Contributor Author

@wbamberg, thanks for all the great suggestions. I think I have integrated them (including a directory name change).

@stephenmcgruer, there was a question about whether there is a default value for "timeout." I looked at the WebAuthn spec [1] which does not specify a default. Should we say nothing? Should we say the timeout is implementation dependent? Something else? Thanks!

[1] https://www.w3.org/TR/webauthn-2/#dom-publickeycredentialcreationoptions-timeout

@wbamberg wbamberg requested a review from a team as a code owner December 1, 2023 00:47
@wbamberg wbamberg requested review from bsmth and removed request for a team December 1, 2023 00:47
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, @ianbjacobs , I reckon this is great. I'll merge this now and if we get an answer about the timeout default value, we can file a follow-up.

@wbamberg wbamberg merged commit 4c5944b into mdn:main Dec 1, 2023
8 checks passed
@ianbjacobs
Copy link
Contributor Author

WHOHOO! Thank you @wbamberg, it's been a pleasure. I really appreciate all the time you devoted to making this happen!

estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
* Create securepaymentconfirmation

* Added secure-payment-confirmation PMI; deprecated basic-card

* Create Using PR API for SPC

* Add spacing

* Add files via upload

* Add bits for SPC to supportedMethods and data

* Fix indent

* Add payment extension

* Editorial / typography fixes

* Formatting fix

* Update index.md

* Update index.md

* Update files/en-us/web/api/payment_request_api/concepts/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/concepts/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update index.md

* Update index.md

* Update index.md

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update index.md

* Update index.md

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update index.md

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add H1

* Removed h1

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

* Rename dialog file

* Fix lint errors

* Delete files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/chrome-tx-dialog.json

* Add tx dialog image

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/web_authentication_api/webauthn_extensions/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/concepts/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Pull link to PMI registry out of SPC definition.

* Adopted proposal including link update

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/payment_request_api/usingwithsecurepaymentconfirmation/index.md

Co-authored-by: wbamberg <[email protected]>

* Rename dir

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/web_authentication_api/webauthn_extensions/index.md

Co-authored-by: wbamberg <[email protected]>

* updated supportedMethods

* Update files/en-us/web/api/paymentrequest/paymentrequest/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/paymentrequest/paymentrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update instance properties

* Alphabetical order
* Data types provided
* {{optional_inline}} added

* Editorial.

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Use lc in directory name

* Update files/en-us/web/api/securepaymentconfirmationrequest/index.md

* Update Payment Request API sidebar

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: wbamberg <[email protected]>
@stephenmcgruer
Copy link

@stephenmcgruer, there was a question about whether there is a default value for "timeout." I looked at the WebAuthn spec [1] which does not specify a default. Should we say nothing? Should we say the timeout is implementation dependent? Something else? Thanks!

There is a suggested default in the WebAuthn spec - https://www.w3.org/TR/webauthn-2/#ref-for-dom-publickeycredentialcreationoptions-timeout . So could reference that, or could say its implementation dependent (which it is).

@ianbjacobs ianbjacobs deleted the spc-202311 branch December 7, 2023 18:14
@ianbjacobs
Copy link
Contributor Author

I now see that the Web Authentication documentation on MDN about timeout is here:
https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/create#timeout

So another option is to reference that definition. However, that definition does not indicate a default.

My preference at this point is to refer to the Web Authentication specification. Stephen, should we also refer to the Web Authentication specification from the SPC definition of timeout?

@stephenmcgruer
Copy link

Stephen, should we also refer to the Web Authentication specification from the SPC definition of timeout?

I would happily review a PR to do so. :)

@ianbjacobs
Copy link
Contributor Author

So let it be written, so let it be done:
w3c/secure-payment-confirmation#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants