Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audit metrics for authenticated access #118

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Oct 31, 2023

What problem is this solving?

We need to monitor the access in the app, checking the graphql operations with authentication access.

How should this be manually tested?

  • Access some audited operation from graphql.
    getAppSettings
    listFeatures
    checkCustomerSchema
    getUserByEmail
    listAllUsers
    listUsers
    deleteRole
    setCurrentOrganization

Screenshots or example usage:
image

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 31, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 31, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@Rudge Rudge requested a review from a team October 31, 2023 01:50
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 184, PR deletions = 43

Generated by 🚫 dangerJS against 4b0740a

Copy link
Contributor

@mairatma mairatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one single suggestion to avoid increasing the latency of the responses.

node/directives/auditAccess.ts Outdated Show resolved Hide resolved
graphql/schema.graphql Outdated Show resolved Hide resolved
@Rudge Rudge requested review from mairatma and a team November 1, 2023 15:35
Copy link
Contributor

@mairatma mairatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Rudge Rudge merged commit f5287aa into master Nov 6, 2023
10 checks passed
@Rudge Rudge deleted the feature/B2BTEAM-1433-security-metrics branch November 6, 2023 15:33
Copy link

vtex-io-ci-cd bot commented Nov 6, 2023

Your PR has been merged! App is being published. 🚀
Version 1.36.0 → 1.37.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants