Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audit metrics for authenticated access #134

Merged
merged 11 commits into from
Nov 6, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Oct 30, 2023

What problem is this solving?

We need to monitor the access in the app, checking the graphql operations with authentication access.

How to test it?

  • Access some audited operation from graphql.
    getOrganizationById
    getCostCenterById
    getOrganizationByIdStorefront
    getCostCenterByIdStorefront
    getSalesChannels
    getCostCentersByOrganizationId
    getOrganizations
    getOrganizationsByEmail
    getB2BSettings
    getMarketingTags
    createOrganizationRequest
    getBinding
    getPaymentTerms

Workspace

Screenshots or example usage:

image

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 30, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@Rudge Rudge requested a review from a team October 30, 2023 19:46
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 161, PR deletions = 22

Generated by 🚫 dangerJS against a6f16a9

@Rudge Rudge force-pushed the feature/B2BTEAM-1433-security-metrics branch from 528e1a3 to 4eb0708 Compare October 30, 2023 20:19
@Rudge Rudge force-pushed the feature/B2BTEAM-1433-security-metrics branch from 4eb0708 to bdcd7a4 Compare October 30, 2023 20:49
node/resolvers/directives/auditAccess.ts Outdated Show resolved Hide resolved
node/resolvers/directives/auditAccess.ts Outdated Show resolved Hide resolved
node/resolvers/directives/withPermissions.ts Outdated Show resolved Hide resolved
node/resolvers/directives/withPermissions.ts Outdated Show resolved Hide resolved
@Rudge Rudge requested review from mairatma, enzomerca and a team October 31, 2023 16:54
@Rudge Rudge force-pushed the feature/B2BTEAM-1433-security-metrics branch from 283e55b to 97a16a5 Compare October 31, 2023 18:54
@Rudge Rudge force-pushed the feature/B2BTEAM-1433-security-metrics branch from 79c61e3 to d1b5fdf Compare October 31, 2023 19:38
mairatma
mairatma previously approved these changes Nov 1, 2023
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Rudge Rudge requested review from mairatma and a team November 6, 2023 14:48
@Rudge Rudge merged commit 68c0d0b into master Nov 6, 2023
10 checks passed
@Rudge Rudge deleted the feature/B2BTEAM-1433-security-metrics branch November 6, 2023 20:00
Copy link

vtex-io-ci-cd bot commented Nov 6, 2023

Your PR has been merged! App is being published. 🚀
Version 0.43.2 → 0.44.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants