Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all translations #684

Closed
wants to merge 11 commits into from
Closed

Fix all translations #684

wants to merge 11 commits into from

Conversation

sheilagomes
Copy link
Collaborator

@sheilagomes sheilagomes commented Nov 6, 2024

Review and fix all translations. Tracked in task LOC-16956

@sheilagomes sheilagomes requested review from a team as code owners November 6, 2024 12:41
@sheilagomes sheilagomes requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team November 6, 2024 12:41
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 6, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@sheilagomes sheilagomes changed the title Review and fix all translations Fix all translations Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Fails
🚫

Please remove the line ## [3.134.0] - 2024-11-07 from CHANGELOG.md
This will be automatically added once this PR is merged.

Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against 1282803

Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@salesfelipe
Copy link
Contributor

Did you rebase or merged with the latest master?

@sheilagomes
Copy link
Collaborator Author

sheilagomes commented Nov 7, 2024

Did you rebase or merged with the latest master?

I did, but I think I inverted the order and pulled from the PR before the master, I'm sorry, my bad.

@salesfelipe
Copy link
Contributor

salesfelipe commented Nov 7, 2024

Closed in favor of #687

@salesfelipe salesfelipe closed this Nov 7, 2024
@salesfelipe salesfelipe deleted the fix/l10n branch November 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants