Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Payment Terms changes not applied in the B2B Checkout Settings #69

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

icaroov
Copy link
Contributor

@icaroov icaroov commented Jul 4, 2024

What problem is this solving?

Updating payment terms in the organization details UI does not apply to B2B checkout settings.

This behavior occurs because the update occurs only for the organization, but B2B checkout settings use cost center information, which is not updated by the organization details UI.

How to test it?

  • Create an organization;
  • In the organization details UI, update the payment terms;
  • Access the website, assemble a cart and access checkout; Payment terms will remain the same.

Workspace

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Jul 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@icaroov
Copy link
Contributor Author

icaroov commented Jul 4, 2024

This current PR replaces and fixes the tests of this other PR: #68.

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 69, PR deletions = 16

Generated by 🚫 dangerJS against 5bf6f7e

CHANGELOG.md Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca July 11, 2024 17:02
@enzomerca
Copy link
Contributor

Approved. Will hold the deployment until next week.

@enzomerca enzomerca merged commit 28ab628 into vtex-apps:master Jul 15, 2024
1 check passed
Copy link

vtex-io-ci-cd bot commented Jul 15, 2024

Your PR has been merged! App is being published. 🚀
Version 1.11.2 → 1.11.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants