Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update payment terms cost center #68

Closed
wants to merge 3 commits into from

Conversation

giurigaud
Copy link

@giurigaud giurigaud commented Jun 11, 2024

What problem is this solving?

Updating payment terms in the organization details UI does not apply to B2B checkout settings.

This behavior occurs because the update occurs only for the organization, but B2B checkout settings use cost center information, which is not updated by the organization details UI.

How to test it?

  • Create an organization;
  • In the organization details UI, update the payment terms;
  • Access the website, assemble a cart and access checkout; Payment terms will remain the same.

Workspace

Screenshots or example usage:

Compartilhamento.de.tela.-.2024-06-11.10h26min24s.mp4
Compartilhamento.de.tela.-.2024-06-11.10h24min47s.mp4

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Jun 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Jun 11, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 19, PR deletions = 9

Generated by 🚫 dangerJS against 45cb882

@enzomerca enzomerca self-requested a review June 12, 2024 13:02
Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested here and it works fine! nice!
Just a small comment and also don't forget to update the CHANGELOG!

node/resolvers/Routes/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@enzomerca
Copy link
Contributor

It turns out we do have some unit tests for this repo. Could you please fix the test that broke and the lint errors?

@enzomerca
Copy link
Contributor

closing in favor of: #69

@enzomerca enzomerca closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants