-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update payment terms cost center #68
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested here and it works fine! nice!
Just a small comment and also don't forget to update the CHANGELOG!
88713d0
to
45cb882
Compare
It turns out we do have some unit tests for this repo. Could you please fix the test that broke and the lint errors? |
closing in favor of: #69 |
What problem is this solving?
Updating payment terms in the organization details UI does not apply to B2B checkout settings.
This behavior occurs because the update occurs only for the organization, but B2B checkout settings use cost center information, which is not updated by the organization details UI.
How to test it?
Workspace
Screenshots or example usage:
Compartilhamento.de.tela.-.2024-06-11.10h26min24s.mp4
Compartilhamento.de.tela.-.2024-06-11.10h24min47s.mp4
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗