UI: Enhancement (#1033) #1034
UI: Enhancement (#1033) #1034
Conversation
|
Those |
|
|
improve(style): status change style of feed page improve(style): feed page
Map1en
force-pushed
the
style-unified-layout-alignments
branch
from
e0e5fc1 to
cb22cd0
Compare
|
This PR has become somewhat disorganized and the content is not well-structured. In the future, I will submit PRs separately for each component. |
This issue can be resolved by using v-if to control the entire tag. If you think generating and unloading the entire page might be problematic, you can also use v-if or clear data in performance-sensitive areas. For example, you can determine if the opened tag page is not the current page, and then unload the DOM. Using v-if and v-show together can lead to additional performance overhead and can be confusing, making it difficult to debug. I think this issue was mentioned in the Vue 2 documentation, but I can't remember for sure. quq |
|
I much prefer these larger PRs personally it's easy for me to manage, and not using both v-if and v-show at the same time makes sense, in most cases clearing data isn't an option due to the use of shared arrays, I think unloading UI that isn't in use is preferred, although I think some things are left loaded in on purpose for elements to keep their last state. |
In performance-sensitive parts, can use keep-alive to retain the instance without destroying it, preserving the state while only adding the DOM. However, this requires splitting into smaller components. For performance-sensitive and reusable parts, this approach is worthwhile. Additionally, many areas currently share data and logic, which is not a good practice. For future optimization and easier maintenance, components should be split. For now, I am trying to only modify the UI parts, and if I encounter any logical issues, I will submit them in others PR. |
|
I'm limiting this PR to these commits since I wasn't quite sure about the ideal PR size. I kept adding commits after learning that larger PRs can be more convenient for review. Looking at what's been done, I think I've managed to fix quite a few basic UI issues, particularly those alignment problems. I'd like to continue contributing more PRs to this project, though it seems there aren't many bugs or features I can work on at the moment. If I continue with UI improvements, the next phase would involve more substantial changes - like modifying the visual presentation (though preferences can vary from person to person) and adapting to other themes (which would require considerable effort). Alternatively, there are other areas to explore, such as code splitting, performance optimization, or other improvements. However, these would involve significant changes, and while I'm interested in working on them, I'd need to get confirmation first. So I'm hoping we can discuss this further, as I'm looking forward to contributing more commits to this project. |
|
I'll start testing these commits soon so I can get them merged, please send me a DM on Discord I have plenty of things I'd like to discuss. |
* ui: Enhancement (vrcx-team#1033) * fix(style): bg color issue when hovering over input count in other themes * fix(style): el-select height of feed tab improve(style): status change style of feed page improve(style): feed page * improve(ui): favorites page * improve(ui): tuning * improve(style): settings page
|
Seems to be setting toggle on Settings-Appearance page got messed up. Ref. https://canary.discord.com/channels/854071236363550763/864248845301710908/1320180810850238596 |
|
this seems to have also caused issues with some settings in the material theme, example being slider buttons no longer being consistent |
Yeah, for reference. FohvtmMgT8.mp4 |
|
Also wanna point out that I'm noticing a lot of text input fields with no clearly defined box boundries.
|
|
tag text also don't seem to be centered anymore |
…#1047) * fix: issues caused by PR(vrcx-team#1034). (vrcx-team#1033) * Manually merge to ensure compatibility with (vrcx-team#1054) PR
Fixed the following issues:
Main Item: User Dialog Box
Avatar Dialog Box
Main Screen
v-ifandv-showsimultaneously; remove conflicts.Search Avatar Page
Settings
Fixed the following issues:
Fixed the following issues:
Feed Page
Favorites Page
• Reorganized search box and sorting methods to top-right corner
• Replaced Switch with RadioGroup for sorting methods (as they represent distinct values, not binary states)
• Similar components will be updated in future PRs
• Restored original colors for friend avatars (removed grey tint, Because it is inconsistent with the behavior of the friends status bar on the right side.)
• Offline status icons updates pending further consideration
• Added "No data" placeholder in empty Collapse components
• Replaced dot indicators with tags for status of world favorites (It can easily cause confusion, we switched to using tags to improve recognition.)
• Redesigned import dialog layouts across all three tabs
• Enhanced export dialogs:
• Adjusted text case displays for consistency
• Basic theme compatibility improvements
(Note: Comprehensive theme adjustments pending due to color hierarchy complexity)
I'm sorry for making such fragmented commits and not following the specific pages.
Fixed the following issues:
Corrected switch alignment on the "Show starred friends only" page
Fixed tag alignment for the world group visibility status in favorites
Adjusted switch alignment in the top-right corner of the favorites page model editor
Added red color to the logout button for better visibility and user recognition
Improved user experience by highlighting save buttons:
Fixed the following issues:
Replaced the switches for non-binary attributes with radio groups on the settings page.
Refined the switch component and adjusted its styling.
Unified the icons for the notification messages to "info."