Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Enhancement #1033

Open
Map1en opened this issue Dec 16, 2024 · 2 comments
Open

[UI] Enhancement #1033

Map1en opened this issue Dec 16, 2024 · 2 comments

Comments

@Map1en
Copy link
Contributor

Map1en commented Dec 16, 2024

This is a tracking issue for UI improvements. I've been working on some UI enhancements recently, I think it's a good idea to create an issue to track these changes.

This includes basic alignment issues, layout organization, and some UX adjustments afterwards.

  • Alignment issues
  • Layout organization
  • UX adjustments

Currently, modifications are made according to the default theme. Later, additional changes will be made to other themes based on the existing style.

If possible, I would appreciate some suggestions so I can have a clear direction for improvement, Thanks.

Related PRs:

Map1en added a commit to Map1en/VRCX that referenced this issue Dec 16, 2024
@Natsumi-sama
Copy link
Member

Kamiyas Material 3 theme supports https://www.npmjs.com/package/@material/material-color-utilities but I never got around to adding it.
They also made another theme that was never added https://github.com/kamiya10/VRCX-theme/tree/main/bg
Maintenance cost of large amounts of themes can add up.
Our UI library element-ui everything is based off of is deprecated.
Upgrading would require switching to Vue3 or another JS framework, essentially requiring a full rewrite making it not a viable option.
These fixes and improvements are most welcome.

@Map1en
Copy link
Contributor Author

Map1en commented Dec 17, 2024

First of all, the current program's functionality is excellent. However, there are many aspects of the UI that could be improved.

Under the default theme, there are already several issues as described in the posts above. My plan is to start with alignment and arrangement: ensuring that most elements are properly aligned and displayed in a more intuitive way.

Next step would be unifying UI components: currently, many similar interactions are not using the same type of component, which likely needs to be corrected.
Lastly, for better UX - this is a long-term consideration and won't be addressed immediately.

Currently, non-default themes have numerous display issues, far more than those in the default theme. These aren't just basic alignment problems - they appear unattractive and are even difficult to use. Furthermore, when modifying the default theme code and changing the existing DOM structure, adapting other themes requires a considerable amount of work. Based on this, I suggest giving lower priority to adapting other themes. To avoid excessive workload, we might even consider temporarily deprecating some themes or pausing their updates.

Natsumi-sama pushed a commit that referenced this issue Dec 20, 2024
* ui: Enhancement (#1033)

* fix(style): bg color issue when hovering over input count in other themes

* fix(style): el-select height of feed tab

improve(style): status change style of feed page

improve(style): feed page

* improve(ui): favorites page

* improve(ui): tuning

* improve(style): settings page
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this issue Dec 21, 2024
* ui: Enhancement (vrcx-team#1033)

* fix(style): bg color issue when hovering over input count in other themes

* fix(style): el-select height of feed tab

improve(style): status change style of feed page

improve(style): feed page

* improve(ui): favorites page

* improve(ui): tuning

* improve(style): settings page
Map1en added a commit to Map1en/VRCX that referenced this issue Dec 24, 2024
Natsumi-sama added a commit to Natsumi-sama/VRCX that referenced this issue Dec 27, 2024
Natsumi-sama pushed a commit that referenced this issue Dec 30, 2024
* fix: issues caused by PR(#1034). (#1033)

* Manually merge to ensure compatibility with (#1054) PR
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this issue Dec 30, 2024
…#1047)

* fix: issues caused by PR(vrcx-team#1034). (vrcx-team#1033)

* Manually merge to ensure compatibility with (vrcx-team#1054) PR
Natsumi-sama pushed a commit that referenced this issue Jan 8, 2025
* refactor: separate SimpleSwitch component using Vue SFC

* fix
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this issue Jan 9, 2025
…) (vrcx-team#1054)

* refactor: separate SimpleSwitch component using Vue SFC

* fix
@Map1en Map1en mentioned this issue Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants