-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed example for zero-shot-detection-transformer-torch #5224
Fixed example for zero-shot-detection-transformer-torch #5224
Conversation
WalkthroughThe changes introduce a new conditional block in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/scripts/make_model_zoo_docs.py (2)
176-176
: Remove unnecessary empty lineThis empty line is inconsistent with the formatting of other conditional blocks in the template.
177-186
: LGTM! Consider enhancing the example's readabilityThe implementation correctly fixes the example by providing the required classes parameter. However, consider these readability improvements:
- Add a comment explaining the zero-shot detection concept
- Format the classes list for better readability
{% elif 'zero-shot-detection-transformer-torch' in name %} + # Demonstrate zero-shot object detection by specifying target classes + # without any training examples model = foz.load_zoo_model( "{{ name }}", - classes=["person", "dog", "cat", "bird", "car", "tree", "chair"] + classes=[ + "person", + "dog", + "cat", + "bird", + "car", + "tree", + "chair", + ] )
9524912
into
voxel51:zero-shot-detection-transformer-torch-example
…-torch-example-release Cherry-picking #5224 for release
What changes are proposed in this pull request?
Fixes #5221. Updated documentation:
How is this patch tested? If it is not, please explain why.
Code tested in Colab: https://colab.research.google.com/drive/1Q5x-uhUcWoo9IVxR7bV-EESakcKWNy74?usp=sharing
Release Notes
Fix: Updated example in Doc for model
zero-shot-detection-transformer-torch
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes