Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example for zero-shot-detection-transformer-torch #5224

Conversation

daniel-bogdoll
Copy link

@daniel-bogdoll daniel-bogdoll commented Dec 5, 2024

What changes are proposed in this pull request?

Fixes #5221. Updated documentation:

image

How is this patch tested? If it is not, please explain why.

Code tested in Colab: https://colab.research.google.com/drive/1Q5x-uhUcWoo9IVxR7bV-EESakcKWNy74?usp=sharing

image

Release Notes

Fix: Updated example in Doc for model zero-shot-detection-transformer-torch

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

coderabbitai bot commented Dec 5, 2024

Walkthrough

The changes introduce a new conditional block in the _render_model_content function of the make_model_zoo_docs.py script. This block specifically handles the model 'zero-shot-detection-transformer-torch', allowing it to load a defined list of classes and apply the model to a dataset. The modifications also adjust the existing conditional structure for model rendering to ensure seamless integration of this new functionality.

Changes

File Change Summary
docs/scripts/make_model_zoo_docs.py Added conditional block for 'zero-shot-detection-transformer-torch' to handle model loading and dataset application. Modified existing conditionals for integration.

Assessment against linked issues

Objective Addressed Explanation
Fix example for 'zero-shot-detection-transformer-torch' (5221)

🐰 In the garden where the models play,
A new friend joins us today!
With classes ready, predictions in sight,
The FiftyOne app shines so bright!
Let's hop along and celebrate,
For zero-shot detection, it’s never too late! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
docs/scripts/make_model_zoo_docs.py (2)

176-176: Remove unnecessary empty line

This empty line is inconsistent with the formatting of other conditional blocks in the template.


177-186: LGTM! Consider enhancing the example's readability

The implementation correctly fixes the example by providing the required classes parameter. However, consider these readability improvements:

  1. Add a comment explaining the zero-shot detection concept
  2. Format the classes list for better readability
 {% elif 'zero-shot-detection-transformer-torch' in name %}
+    # Demonstrate zero-shot object detection by specifying target classes
+    # without any training examples
     model = foz.load_zoo_model(
         "{{ name }}",
-        classes=["person", "dog", "cat", "bird", "car", "tree", "chair"]
+        classes=[
+            "person",
+            "dog",
+            "cat",
+            "bird",
+            "car",
+            "tree",
+            "chair",
+        ]
     )
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1649f2f and 06cab9a.

📒 Files selected for processing (1)
  • docs/scripts/make_model_zoo_docs.py (1 hunks)

@brimoor brimoor changed the base branch from develop to zero-shot-detection-transformer-torch-example December 5, 2024 18:01
@brimoor brimoor merged commit 9524912 into voxel51:zero-shot-detection-transformer-torch-example Dec 5, 2024
8 of 9 checks passed
brimoor added a commit that referenced this pull request Dec 5, 2024
…-torch-example-release

Cherry-picking #5224 for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] zero-shot-detection-transformer-torch example not working
2 participants