-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picking #5224 for release #5225
Cherry-picking #5224 for release #5225
Conversation
WalkthroughThe changes introduce a new conditional block in the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/scripts/make_model_zoo_docs.py (1)
176-184
: Consider adding a second example demonstrating custom classes.Since this is a zero-shot detection model, it would be helpful to show users how to use their own custom classes, similar to how the CLIP model example demonstrates this flexibility.
Here's a suggested addition to the template:
session = fo.launch_app(dataset) + # + # Make predictions with custom classes + # + + model = foz.load_zoo_model( + "{{ name }}", + classes=["airplane", "boat", "traffic light", "stop sign", "pizza"], + ) + + dataset.apply_model(model, label_field="custom_predictions") + session.refresh()
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
docs/scripts/make_model_zoo_docs.py
(1 hunks)
🔇 Additional comments (1)
docs/scripts/make_model_zoo_docs.py (1)
176-184
: LGTM! The template changes look good.
The new conditional block for 'zero-shot-detection-transformer-torch' follows the established pattern and provides a clear example of model usage with predefined classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Cherry-picking #5224 for release
Summary by CodeRabbit