Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Pin xgrammar to 0.1.11 #13338

Merged
merged 1 commit into from
Feb 16, 2025
Merged

[Bugfix] Pin xgrammar to 0.1.11 #13338

merged 1 commit into from
Feb 16, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 15, 2025

There seems to be an breaking change to the apply_token_bitmask_inplace_cuda op in the latest release of xgrammar 0.1.13, so let's pin for now to fix

https://vllm-dev.slack.com/archives/C07R5PAL2L9/p1739652025939989?thread_ts=1739650060.428689&cid=C07R5PAL2L9

[2025-02-15T00:55:01Z]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/guided_decoding/xgrammar_decoding.py", line 343, in __call__
[2025-02-15T00:55:01Z]     xgr.apply_token_bitmask_inplace(
[2025-02-15T00:55:01Z]   File "/usr/local/lib/python3.12/dist-packages/xgrammar/matcher.py", line 133, in apply_token_bitmask_inplace
[2025-02-15T00:55:01Z]     apply_token_bitmask_inplace_cuda(logits, bitmask, indices)
[2025-02-15T00:55:01Z]   File "/usr/local/lib/python3.12/dist-packages/xgrammar/kernels/apply_token_bitmask_inplace_cuda.py", line 77, in apply_token_bitmask_inplace_cuda
[2025-02-15T00:55:01Z]     torch.ops.xgrammar.apply_token_bitmask_inplace_cuda(logits, bitmask, indices)
[2025-02-15T00:55:01Z]   File "/usr/local/lib/python3.12/dist-packages/torch/_ops.py", line 1116, in __call__
[2025-02-15T00:55:01Z]     return self._op(*args, **(kwargs or {}))
[2025-02-15T00:55:01Z]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[2025-02-15T00:55:01Z] RuntimeError: bitmask must have the hidden size equal to ceilDiv(vocabSize, 32).

There seems to be an breaking change to the apply_token_bitmask_inplace_cuda op in the latest release, so let's pin for now to fix
@mergify mergify bot added the ci/build label Feb 15, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 15, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 16, 2025 03:42
@simon-mo simon-mo merged commit d3d547e into main Feb 16, 2025
79 of 88 checks passed
@simon-mo simon-mo deleted the xgrammar-0.1.11 branch February 16, 2025 03:42
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
mgawarkiewicz added a commit to HabanaAI/vllm-fork that referenced this pull request Feb 19, 2025
Fix issue seen in guided_json. It's related to vllm-project#13338
macnowicki added a commit to HabanaAI/vllm-fork that referenced this pull request Feb 19, 2025
Fix issue seen in guided_json. Fix is related to
vllm-project#13338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants