Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Enable regex support with xgrammar #13228

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

russellb
Copy link
Member

xgrammar 0.1.12 has fixes that should allow us to turn on regex
support.

This PR is a draft pending 0.1.12 to make it to pypi mirrors
and for #12632 to merge first, since this would conflict with
the changes there.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to check xgrammar version and print out warning if they are using an old version?

@russellb
Copy link
Member Author

Would it be a good idea to check xgrammar version and print out warning if they are using an old version?

hm, I'm not sure we do that other places. We just assume the code has what we express is required in the requirements files. You're on your own if you veer outside of that!

Copy link

mergify bot commented Feb 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 15, 2025
Copy link

@Ubospica Ubospica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work fine with xgrammar. Thanks @russellb !

Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
This interface didn't exist when I first worked on this. We can use
the simpler interface now.

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb marked this pull request as ready for review February 18, 2025 02:08
@russellb russellb requested a review from mgoin as a code owner February 18, 2025 02:08
@russellb russellb marked this pull request as draft February 18, 2025 02:35
@russellb
Copy link
Member Author

marked as a draft again as the pin to 0.1.11 is intentional to avoid a bug introduced in 0.1.13. I'll revisit this again after a release that resolves the bug in question.

#13338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants