Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-2006 - Remove filter from SubmitTrainingJobRequest in API #402

Merged
merged 7 commits into from
Dec 4, 2023
Merged

DATA-2006 - Remove filter from SubmitTrainingJobRequest in API #402

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dd16285
DATA-2006 - Remove filter from SubmitTrainingJobRequest in API
tahiyasalam Nov 27, 2023
76ead1a
Remove import
tahiyasalam Nov 27, 2023
21a96c4
Generated files
tahiyasalam Nov 27, 2023
a278a13
Revert "Generated files"
tahiyasalam Nov 29, 2023
5e5166d
Built new protos from a278a13
github-actions[bot] Nov 29, 2023
abd6f0b
Merge branch 'main' into remove-filter-training
tahiyasalam Nov 30, 2023
f8c7f76
Merge branch 'main' into remove-filter-training
agreenb Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions proto/viam/app/mltraining/v1/ml_training.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

package viam.app.mltraining.v1;

import "app/data/v1/data.proto";
import "google/protobuf/timestamp.proto";
import "google/rpc/status.proto";
import "tagger/v1/tagger.proto";
Expand Down Expand Up @@ -33,14 +32,16 @@
MODEL_TYPE_OBJECT_DETECTION = 3;
}

message SubmitTrainingJobRequest {

Check failure on line 35 in proto/viam/app/mltraining/v1/ml_training.proto

View workflow job for this annotation

GitHub Actions / Test For Lint and Breaking Changes 

Previously present field "1" with name "filter" on message "SubmitTrainingJobRequest" was deleted.
viam.app.data.v1.Filter filter = 1 [(tagger.v1.tags) = "bson:\"filter\" json:\"filter\""];
string dataset_id = 7 [(tagger.v1.tags) = "bson:\"dataset_id\" json:\"dataset_id\""];
string organization_id = 2 [(tagger.v1.tags) = "bson:\"organization_id\" json:\"organization_id\""];
string model_name = 3 [(tagger.v1.tags) = "bson:\"model_name\" json:\"model_name\""];
string model_version = 4 [(tagger.v1.tags) = "bson:\"model_version\" json:\"model_version\""];
ModelType model_type = 5 [(tagger.v1.tags) = "bson:\"model_type\" json:\"model_type\""];
repeated string tags = 6 [(tagger.v1.tags) = "bson:\"tags\" json:\"tags\""];

reserved 1;
reserved "filter";
}

message SubmitTrainingJobResponse {
Expand Down
Loading