DATA-2006 - Remove filter from SubmitTrainingJobRequest in API #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 21a96c4.
agreenb
approved these changes
Nov 29, 2023
|
@Simberific would you mind manually merging? This is based on this scope doc, where we decided we would disallow training on data by filter and only support training on data in dataset. |
|
Hi Tahiya - so sorry I missed this. Do you still need assistance?
…On Thu, Nov 30, 2023 at 9:18 AM tahiyasalam ***@***.***> wrote:
@Simberific <https://github.com/Simberific> would you mind manually
merging? This is based on this scope doc
<https://docs.google.com/document/d/1D6TGiQ9n1qip1jW2O_dg5ahNv__1O_pZztqwT3hF7fI/edit?usp=sharing>,
where we decided we would disallow training on data by filter and only
support training on data in dataset.
—
Reply to this email directly, view it on GitHub
<#402 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA4B2R6OWK7Q3FZ24Z4D7TYHCITFAVCNFSM6AAAAAA74FHNDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTHA3DMOBWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Looks like I'm currently |
|
Thank you!
…On Mon, Dec 4, 2023 at 4:57 PM Simone Kalmakis ***@***.***> wrote:
Looks like I'm currently member - just asked Steve to bump my permissions
so I can squash & merge.
—
Reply to this email directly, view it on GitHub
<#402 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA46OPECEI2YXXTZZFRR3FLYHZBLJAVCNFSM6AAAAAA74FHNDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGU2TANRXGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cross-referenced this PR against both https://github.com/viamrobotics/app/pull/3010 and viamrobotics/rdk#3267, where tests in all scenarios and there was no reference to the
GetFilterfield. Once merged, I will double pull intoappand complete the last change which is removing thefilter: undefinedfield from the FE