Fix crash with invalid arrival_time in libwebrtc bwe #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmillan
approved these changes
Jan 24, 2023
ibc
approved these changes
Jan 24, 2023
|
What concerns me is the root cause of this. It does prevent crash, but why was it set to invalid value in the first place? Maybe #357 should not be closed yet? |
|
Since there is an ongoing effort to update libwebrtc, IMHO it's better to forget about this bug. If it happens once libwebrtc is updated in mediasoup, we'll have to investigate it from scratch anyway. |
This was referenced Jan 26, 2023
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #357
According to the assert
complete_time_msis <0 and it cannot be -1 because there is a check before for that. So the value is probably int64.min().This fix try to avoid ever setting
complete_time_msto any negative value what should prevent the crash from happening.