Fix crash with invalid arrival_time in libwebrtc bwe (#985)

versatica · Jan 24, 2023 · ce3d567 · ce3d567
1 parent 697394a
commit ce3d567
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/worker/deps/libwebrtc/libwebrtc/modules/remote_bitrate_estimator/inter_arrival.cc b/worker/deps/libwebrtc/libwebrtc/modules/remote_bitrate_estimator/inter_arrival.cc
@@ -41,6 +41,11 @@ bool InterArrival::ComputeDeltas(uint32_t timestamp,
   MS_ASSERT(timestamp_delta != nullptr, "timestamp_delta is null");
   MS_ASSERT(arrival_time_delta_ms != nullptr, "arrival_time_delta_ms is null");
   MS_ASSERT(packet_size_delta != nullptr, "packet_size_delta is null");
+  // Ignore packets with invalid arrival time.
+  if (arrival_time_ms < 0) {
+    MS_WARN_TAG(bwe, "invalid arrival time %" PRIi64, arrival_time_ms);
+    return false;
+  }
   bool calculated_deltas = false;
   if (current_timestamp_group_.IsFirstPacket()) {
     // We don't have enough data to update the filter, so we store it until we