Use a data transfer object instead of direct model encoding/decoding #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoffy
approved these changes
Apr 2, 2024
MahdiBM
reviewed
Apr 2, 2024
0xTim
requested changes
Apr 9, 2024
0xTim
approved these changes
May 6, 2024
gwynne
force-pushed
the
dtos
branch
7 times, most recently
from
8399e4b to
a230d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current recommendation when working with Fluent models is to use DTOs (data transfer objects) when decoding requests and encoding responses, rather than conforming the models themselves to
Contentas has been done historically. Our template project should reflect that recommendation.Also includes tests for the
TodoControllerroutes when Fluent is selected.