DTO/model conversions should be functions, not properties.

vapor · May 6, 2024 · 729b5da · 729b5da
1 parent e3f4d4a
commit 729b5da
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Sources/App/Controllers/TodoController.swift b/Sources/App/Controllers/TodoController.swift
@@ -13,14 +13,14 @@ struct TodoController: RouteCollection {
     }
 
     func index(req: Request) async throws -> [TodoDTO] {
-        try await Todo.query(on: req.db).all().map(\.dto)
+        try await Todo.query(on: req.db).all().map { $0.toDTO() }
     }
 
     func create(req: Request) async throws -> TodoDTO {
-        let todo = try req.content.decode(TodoDTO.self).model
+        let todo = try req.content.decode(TodoDTO.self).toModel()
 
         try await todo.save(on: req.db)
-        return todo.dto
+        return todo.toDTO()
     }
 
     func delete(req: Request) async throws -> HTTPStatus {

diff --git a/Sources/App/DTOs/TodoDTO.swift b/Sources/App/DTOs/TodoDTO.swift
@@ -5,7 +5,7 @@ struct TodoDTO: Content {
     var id: UUID?
     var title: String?
 
-    var model: Todo {
+    func toModel() -> Todo {
         let model = Todo()
 
         model.id = self.id

diff --git a/Sources/App/Models/Todo.swift b/Sources/App/Models/Todo.swift
@@ -19,7 +19,7 @@ final class Todo: Model, @unchecked Sendable {
         self.title = title
     }
 
-    var dto: TodoDTO {
+    func toDTO() -> TodoDTO {
         .init(
             id: self.id,
             title: self.$title.value