Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Fix NPM CD tag #3155

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Node: Fix NPM CD tag #3155

merged 6 commits into from
Feb 13, 2025

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Feb 13, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3157

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jamesx-improving
Node: Fix NPM CD tag
310f83c 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving jamesx-improving requested a review from a team as a code owner February 13, 2025 00:10
@jamesx-improving
CHANGELOG
60a1a82 
Signed-off-by: James Xin <[email protected]>
jbrinkman
jbrinkman approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the change avifenesh identified.

avifenesh
avifenesh requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just want to take extra step to be safe, since it can break users prod

@jamesx-improving
address comment
a08b17d 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving
Copy link
Collaborator Author

Looks good, just want to take extra step to be safe, since it can break users prod

Hi Avi,

Is the Changes requested comment type intentional? If so, what change are you requesting?

@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper CI/CD CI/CD related labels Feb 13, 2025
@jamesx-improving jamesx-improving merged commit 3b206ef into main Feb 13, 2025
11 of 12 checks passed
@jamesx-improving jamesx-improving deleted the node/jamesx-fix-npm-tag branch February 13, 2025 18:32
@jamesx-improving jamesx-improving mentioned this pull request Feb 13, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@avifenesh avifenesh avifenesh approved these changes

@barshaul barshaul Awaiting requested review from barshaul

Assignees
No one assigned
Labels
CI/CD CI/CD related node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesx-improving @jbrinkman @avifenesh @Yury-Fridlyand