Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Fix NPM CD tag on release-1.3 #3163

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Node: Fix NPM CD tag on release-1.3 #3163

merged 2 commits into from
Feb 13, 2025

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Feb 13, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3157

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Backport of #3155 to release-1.3

@jamesx-improving jamesx-improving added node Node.js wrapper CI/CD CI/CD related labels Feb 13, 2025
@jamesx-improving jamesx-improving added this to the 1.3 milestone Feb 13, 2025
@jamesx-improving jamesx-improving requested a review from a team as a code owner February 13, 2025 19:44
yipin-chen
yipin-chen approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to update CHANGELOG?

@jamesx-improving
CHANGELOG
5ed99ab 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving
Copy link
Collaborator Author

LGTM. Do we need to update CHANGELOG?

Change log added.

@jamesx-improving jamesx-improving merged commit cae138e into release-1.3 Feb 13, 2025
11 of 12 checks passed
@jamesx-improving jamesx-improving deleted the node/jamesx-fix-npm-tag-1.3 branch February 13, 2025 21:28
@yipin-chen yipin-chen mentioned this pull request Feb 18, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related node Node.js wrapper
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesx-improving @yipin-chen