Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Fix lpopCount null handling #3025

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Java: Fix lpopCount null handling #3025

merged 3 commits into from
Jan 29, 2025
+5 −4

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Jan 29, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3024

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jamesx-improving jamesx-improving requested a review from a team as a code owner January 29, 2025 07:12
@jamesx-improving
CHANGELOG
7947cf8 
Signed-off-by: James Xin <[email protected]>
jamesx-improving
jamesx-improving commented Jan 29, 2025
View reviewed changes
java/integTest/src/test/java/glide/standalone/StandaloneClientTests.java
Comment on lines -26 to -27
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collateral spotless damage from #3022

jbrinkman
jbrinkman approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Jan 29, 2025
Yury-Fridlyand
Yury-Fridlyand approved these changes Jan 29, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jamesx-improving
fix CHANGELOG
942886b 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving jamesx-improving merged commit 17a91b2 into main Jan 29, 2025
15 of 16 checks passed
@jamesx-improving jamesx-improving deleted the java/jamesx-lpopcount-fix-null-handling branch January 29, 2025 20:42
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jbrinkman jbrinkman jbrinkman approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesx-improving @jbrinkman @Yury-Fridlyand @yipin-chen