Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Missing null handing at lpopCount #3024

Closed
naoh-dw opened this issue Jan 28, 2025 · 3 comments
Closed

Java: Missing null handing at lpopCount #3024

naoh-dw opened this issue Jan 28, 2025 · 3 comments
Assignees
@yipin-chen
Labels
bug Something isn't working java issues and fixes related to the java client User issue Issue openned by users Users Pain An issue known to cause users pain, generaly open by the user.
Milestone
1.3

Comments

@naoh-dw
Copy link

naoh-dw commented Jan 28, 2025

Describe the bug

Java valkey-glide lpopCount is unable to handle missing key.

Expected Behavior

Got null on lpopCount.
ref

Current Behavior

I got error.

glide.api.models.exceptions.GlideException: Unexpected return type from Glide: got null expected Object[]
    at glide.api.BaseClient.handleValkeyResponse(BaseClient.java:522)
    at glide.api.BaseClient.handleArrayResponse(BaseClient.java:580)
    at glide.api.BaseClient.lambda$lpopCount$15(BaseClient.java:1387)

Reproduction Steps

client.lpopCount("missing_key", 123)

Possible Solution

Use handleArrayOrNullResponse instead of handleArrayResponse in lpopCount

Additional Information/Context

No response

Client version used

1.2.1

Engine type and version

Valkey 7.0

OS

any

Language

Java

Language Version

any

Cluster information

No response

Logs

No response

Other information

No response
@naoh-dw naoh-dw added the bug Something isn't working label Jan 28, 2025
@avifenesh avifenesh added java issues and fixes related to the java client Users Pain An issue known to cause users pain, generaly open by the user. Unatriaged user issue Issue open by user and wasn't triaged yet User issue Issue openned by users labels Jan 29, 2025
@avifenesh
Copy link
Collaborator

avifenesh commented Jan 29, 2025 •
edited
Loading

Thanks for opening the issue. Will be fixed!

@yipin-chen yipin-chen self-assigned this Jan 29, 2025
@yipin-chen yipin-chen added this to the 1.3 milestone Jan 29, 2025
@yipin-chen
Copy link
Collaborator

We will fix this issue and it will be included in Release 1.3 (mid-February).

@avifenesh avifenesh removed the Unatriaged user issue Issue open by user and wasn't triaged yet label Jan 29, 2025
@naoh-dw naoh-dw changed the title Java: (short issue description) Java: Missing null handing at lpopCount Jan 29, 2025
@jamesx-improving jamesx-improving mentioned this issue Jan 29, 2025
Merged
6 tasks
@Yury-Fridlyand
Copy link
Collaborator

Fixed by #3025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yipin-chen yipin-chen

Labels
bug Something isn't working java issues and fixes related to the java client User issue Issue openned by users Users Pain An issue known to cause users pain, generaly open by the user.
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.3
Development

No branches or pull requests
4 participants
@avifenesh @naoh-dw @Yury-Fridlyand @yipin-chen