Skip to content

Commit

Permalink
fix(bundler-okam): prefer use lessLoader.modifyVars than theme (#874)
Browse files Browse the repository at this point in the history
  • Loading branch information
sorrycc authored Jan 17, 2024
1 parent 2e6b367 commit 98d0e6b
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 1 deletion.
11 changes: 11 additions & 0 deletions e2e/fixtures.umi/config.less.modifyVars/.umirc.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
export default {
mfsu: false,
theme: {
'@primary-color': 'red',
},
lessLoader: {
modifyVars: {
'@primary-color': 'blue',
},
},
};
8 changes: 8 additions & 0 deletions e2e/fixtures.umi/config.less.modifyVars/expect.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const assert = require("assert");
const { parseBuildResult, moduleReg } = require("../../../scripts/test-utils");
const { files } = parseBuildResult(__dirname);

let content = files["umi.css"];
content = content.replace(/\s/g, "");

assert(content.includes(`color:blue;`), "should prefer less.modifyVars than config.theme");
3 changes: 3 additions & 0 deletions e2e/fixtures.umi/config.less.modifyVars/pages/index.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.a {
color: @primary-color;
}
3 changes: 3 additions & 0 deletions e2e/fixtures.umi/config.less.modifyVars/pages/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import React from 'react';
import './index.less';
export default () => <div>1</div>;
2 changes: 1 addition & 1 deletion packages/bundler-okam/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ exports.build = async function (opts) {
config: opts.config,
// NOTICE: 有个缺点是 如果 alias 配置是 mako 插件修改的 less 这边就感知到不了
alias: okamConfig.resolve.alias,
modifyVars: opts.config.theme,
modifyVars: opts.config.lessLoader?.modifyVars || opts.config.theme,
sourceMap: getLessSourceMapConfig(okamConfig.devtool),
}),
},
Expand Down

0 comments on commit 98d0e6b

Please sign in to comment.