chore: integrate opts.react for umi (#873)

umijs · Jan 16, 2024 · 2e6b367 · 2e6b367
1 parent 6e957ed
commit 2e6b367
Show file tree

Hide file tree

Showing 8 changed files with 35 additions and 0 deletions.
diff --git a/e2e/fixtures.umi/react-16/.gitignore b/e2e/fixtures.umi/react-16/.gitignore
@@ -0,0 +1 @@
+node_modules
diff --git a/e2e/fixtures.umi/react-16/.umirc.ts b/e2e/fixtures.umi/react-16/.umirc.ts
@@ -0,0 +1,3 @@
+export default {
+  mfsu: false,
+};
diff --git a/e2e/fixtures.umi/react-16/expect.js b/e2e/fixtures.umi/react-16/expect.js
@@ -0,0 +1,7 @@
+const assert = require("assert");
+const { parseBuildResult, moduleReg } = require("../../../scripts/test-utils");
+const { files } = parseBuildResult(__dirname);
+
+let content = files["umi.js"];
+
+assert(content.includes(`_react.default.createElement(`), "should use classical runtime since react is 16");
diff --git a/e2e/fixtures.umi/react-16/package.json b/e2e/fixtures.umi/react-16/package.json
@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "react": "16"
+  }
+}
diff --git a/e2e/fixtures.umi/react-16/pages/index.tsx b/e2e/fixtures.umi/react-16/pages/index.tsx
@@ -0,0 +1,2 @@
+import React from 'react';
+export default () => <div>1</div>;
diff --git a/packages/bundler-okam/index.js b/packages/bundler-okam/index.js
@@ -565,6 +565,7 @@ async function getOkamConfig(opts) {
     externals: externalsConfig,
     clean,
     flexBugs: true,
+    react: opts.react || {},
     ...(opts.disableCopy ? { copy: [] } : { copy: ['public'].concat(copy) }),
   };
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -3,3 +3,4 @@ packages:
   - 'crates/node'
   - 'packages/*'
   - 'crates/mako/test/compile/auto-code-splitting'
+  - 'e2e/fixtures.umi/react-16'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import React from 'react';
		export default () => <div>1</div>;