Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exmllent:0.1.0, handy-dora:0.1.0 and zebraw:0.1.0 #1510
exmllent:0.1.0, handy-dora:0.1.0 and zebraw:0.1.0 #1510
Changes from 8 commits
6dee292
c1b01ae
e231e68
27d48a3
19cb32e
c677468
ff1cf23
67c576a
ce06857
5441b34
13b5cc6
a3e188a
793e658
60b9a0a
6885766
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work as expected, because
xml
can only read files from the current package. The user of your package should call it and pass the resulting string as an argument to your function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you could compress this file, to not bloat the repository too much. You can use
oxipng
for that (or any image editing program).Check warning on line 3 in packages/preview/mahjong-tiles/0.1.0/mod.typ
Typst package check / @preview/mahjong-tiles:0.1.0
packages/preview/mahjong-tiles/0.1.0/mod.typ#L3
Check warning on line 3 in packages/preview/mahjong-tiles/0.1.0/mod.typ
Typst package check / @preview/mahjong-tiles:0.1.0
packages/preview/mahjong-tiles/0.1.0/mod.typ#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is too descriptive of what the package does. Could you please change it to something more unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this description could be improved. I personally don't know what riichi-hand-rs is, and I believe a lot of people don't either. Something along the lines of "Render Mahjong tiles" would be better.