exmllent:0.1.0, handy-dora:0.1.0 and zebraw:0.1.0 #1510
Conversation
typst-package-check
bot
changed the title
| @@ -0,0 +1,198 @@ | |||
| #let xml-to-worksheets(xml-path) = { | |||
| let workbook = xml(xml-path).filter(e => if e.tag == "" { false } else { true }).first() | |||
There was a problem hiding this comment.
This won't work as expected, because xml can only read files from the current package. The user of your package should call it and pass the resulting string as an argument to your function.
| version = "0.1.0" | ||
| entrypoint = "lib.typ" | ||
| authors = ["hongjr03 <https://github.com/hongjr03>"] | ||
| description = "Riichi-hand-rs but in Typst." |
There was a problem hiding this comment.
In my opinion, this description could be improved. I personally don't know what riichi-hand-rs is, and I believe a lot of people don't either. Something along the lines of "Render Mahjong tiles" would be better.
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
| name = "mahjong-tiles" | |||
There was a problem hiding this comment.
This name is too descriptive of what the package does. Could you please change it to something more unique?
There was a problem hiding this comment.
It would be nice if you could compress this file, to not bloat the repository too much. You can use oxipng for that (or any image editing program).
|
Thanks for your review! I'll fix these quickly. |
typst-package-check
bot
changed the title
|
|
||
| ## Usage | ||
|
|
||
| Start with `#import "src/lib.typ": mahjong`. Reminds that `handy-dora.wasm` should be in the same directory as where `src/` is. |
There was a problem hiding this comment.
Same here (and the second sentence is then no longer necessary).
| Start with `#import "src/lib.typ": mahjong`. Reminds that `handy-dora.wasm` should be in the same directory as where `src/` is. | |
| Start with `#import "@preview/handy-dora:0.1.0": mahjong`. |
Thanks for your kind work! |
|
Thanks! |
I am submitting
Description:
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE