Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump prettier and stylelint #2775

Closed
wants to merge 4 commits into from
Closed

build(deps-dev): Bump prettier and stylelint #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc157ab
update prettier and stylelint
werdnanoslen Feb 20, 2024
8acbdf0
Merge branch 'main' into an-stylelint-2748
werdnanoslen Mar 4, 2024
676c623
update yarn.lock
werdnanoslen Mar 4, 2024
1b0552d
Merge branch 'main' into an-stylelint-2748
werdnanoslen Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/styles/_overrides.scss
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using a more targeted rule (see summary above) in the rc file, but lint just ignored it. If anyone finds a way of making that work, remove these comment lines

Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@
.usa-language__submenu .usa-language__submenu-item button {
color: color('white');
display: block;
// stylelint-disable-next-line scss/function-no-unknown
line-height: line-height($theme-navigation-font-family, 3);
// stylelint-disable-next-line scss/function-no-unknown
padding: units(1);
text-decoration: none;
width: 100%; /* this is something that was actually missing when we were doing the extend because button widths hve different default widths than block element links */
&:focus {
// stylelint-disable-next-line scss/function-no-unknown
outline-offset: units('neg-05');
}

Expand Down
Loading
Loading