Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump prettier and stylelint #2775

Closed
wants to merge 4 commits into from

Conversation

werdnanoslen
Copy link
Contributor

@werdnanoslen werdnanoslen commented Feb 20, 2024

Summary

Updates prettier and stylelint deps. Dependabot for some reason isn't updating stylelint, so that might need a follow-up investigation or perhaps this triggers its attention 🤷 . Anyway, stylelint being outdated was causing some errors in dependabot's upgrade of prettier in #2748. So this upgrades both and also tells it to ignore USWDS functions in our _overrides file. For some reason, stylelint accepted as valid, but did not seem to use, the proper way (vs the disable-next-line way in this PR) of ignoring them in the rc file:

    "function-no-unknown": [
      true, 
      {
        "ignoreFunctions": ["line-height", "units"]
      }
    ]

Related Issues or PRs

Supersedes and fixes lint error in #2748

How To Test

yarn lint should return no warnings or errors

Screenshots (optional)

also ignore USWDS functions in overrides
@werdnanoslen werdnanoslen requested a review from a team as a code owner February 20, 2024 20:03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using a more targeted rule (see summary above) in the rc file, but lint just ignored it. If anyone finds a way of making that work, remove these comment lines

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 676c623

@werdnanoslen
Copy link
Contributor Author

Superceded by #2716

@werdnanoslen werdnanoslen deleted the an-stylelint-2748 branch June 24, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant