Less clones & consistent search result indexes

CHANGELOG.md

@@ -26,6 +26,7 @@
 - Fix(tui): not having the current theme selected when entering Theme preview tab.
 - Fix(tui): actually report any errors when adding to the playlist. (Like "invalid file type")
 - Fix(tui): sort Music-Library content Alphanumerically.
+- Fix(tui): consistent numbering of results in a search popup.
 - Fix(tui): let `ueberzug` command inherit `stdout` to display chafa.
 
 ### [V0.9.1]

lib/src/library_db/mod.rs

@@ -325,13 +325,13 @@ impl DataBase {
         let conn = self.conn.lock();
         let mut stmt = conn.prepare(search_str)?;
 
-        let vec_records: Vec<TrackDB> = stmt
+        let maybe_record: Option<TrackDB> = stmt
             .query_map([file_path], TrackDB::try_from_row_named)?
             .flatten()
-            .collect();
+            .next();
 
-        if let Some(record) = vec_records.first() {
-            return Ok(record.clone());
+        if let Some(record) = maybe_record {
+            return Ok(record);
         }
 
         Err(Error::QueryReturnedNoRows)

lib/src/playlist/mod.rs

@@ -59,7 +59,7 @@ impl PlaylistValue {
             let as_path = url
                 .to_file_path()
                 .map_err(|()| anyhow!("Failed to convert URL to Path!"))
-                .context(url.to_string())?;
+                .with_context(|| url.to_string())?;
             *self = Self::Path(as_path);
         }
 

lib/src/podcast/mod.rs

@@ -71,12 +71,8 @@ pub struct PodcastFeed {
 
 impl PodcastFeed {
     #[must_use]
-    pub fn new(id: Option<i64>, url: &str, title: Option<String>) -> Self {
-        Self {
-            id,
-            url: url.to_string(),
-            title,
-        }
+    pub const fn new(id: Option<i64>, url: String, title: Option<String>) -> Self {
+        Self { id, url, title }
     }
 }
 
@@ -97,7 +93,7 @@ pub fn check_feed(feed: PodcastFeed, max_retries: usize, tp: &TaskPool, tx_to_ma
             },
             Err(err) => {
                 error!("get_feed_data had a Error: {:#?}", err);
-                let _ = tx_to_main.send(Msg::Podcast(PCMsg::Error(feed.url.to_string(), feed)));
+                let _ = tx_to_main.send(Msg::Podcast(PCMsg::Error(feed)));
             }
         }
     });
@@ -315,27 +311,23 @@ pub fn import_from_opml(db_path: &Path, config: &PodcastSettings, file: &Path) -
         match message {
             Msg::Podcast(PCMsg::NewData(pod)) => {
                 msg_counter += 1;
-                let title = pod.title.clone();
+                let title = &pod.title;
                 let db_result = db_inst.insert_podcast(&pod);
                 match db_result {
                     Ok(_) => {
                         println!("Added {title}");
                     }
-                    Err(_err) => {
+                    Err(err) => {
                         failure = true;
-                        error!("Error adding {title}");
+                        error!("Error adding {title}, err: {err}");
                     }
                 }
             }
 
-            Msg::Podcast(PCMsg::Error(_, feed)) => {
+            Msg::Podcast(PCMsg::Error(feed)) => {
                 msg_counter += 1;
                 failure = true;
-                if let Some(t) = feed.title {
-                    error!("Error retrieving RSS feed: {t}");
-                } else {
-                    error!("Error retrieving RSS feed");
-                }
+                error!("Error retrieving RSS feed: {}", feed.url);
             }
 
             Msg::Podcast(PCMsg::SyncData((_id, _pod))) => {
@@ -394,7 +386,7 @@ fn import_opml_feeds(xml: &str) -> Result<Vec<PodcastFeed>> {
                     Some(pod.text)
                 }
             });
-            feeds.push(PodcastFeed::new(None, &pod.xml_url.unwrap(), title));
+            feeds.push(PodcastFeed::new(None, pod.xml_url.unwrap(), title));
         }
     }
     Ok(feeds)

lib/src/types.rs

@@ -398,7 +398,7 @@ pub enum PCMsg {
     PodcastAddPopupCloseCancel,
     SyncData((i64, PodcastNoId)),
     NewData(PodcastNoId),
-    Error(String, PodcastFeed),
+    Error(PodcastFeed),
     PodcastSelected(usize),
     DescriptionUpdate,
     EpisodeAdd(usize),

tui/src/ui/components/config_editor/key_combo.rs

@@ -301,9 +301,9 @@ impl InputStates {
 
     /// ### `render_value_chars`
     ///
-    /// Render value as a vec of chars
-    pub fn render_value_chars(&self) -> Vec<char> {
-        self.input.clone()
+    /// Get the current input as a slice
+    pub fn render_value_chars(&self) -> &[char] {
+        &self.input
     }
 
     /// ### `get_value`
@@ -469,7 +469,7 @@ impl KeyCombo {
             .states
             .choices
             .iter()
-            .map(|x| ListItem::new(Span::from(x.clone())))
+            .map(|x| ListItem::new(Span::from(x)))
             .collect();
         let mut foreground = self
             .props
@@ -490,9 +490,9 @@ impl KeyCombo {
             .constraints([Constraint::Length(2), Constraint::Min(1)].as_ref())
             .split(area);
         // Render like "closed" tab in chunk 0
-        let selected_text: String = match self.states.choices.get(self.states.selected) {
-            None => String::default(),
-            Some(s) => s.clone(),
+        let selected_text = match self.states.choices.get(self.states.selected) {
+            None => "",
+            Some(s) => s.as_str(),
         };
         let borders = self
             .props
@@ -656,9 +656,9 @@ impl KeyCombo {
                 style = style_invalid;
             }
         }
-        let selected_text: String = match self.states.choices.get(self.states.selected) {
-            None => String::default(),
-            Some(s) => s.clone(),
+        let selected_text = match self.states.choices.get(self.states.selected) {
+            None => "",
+            Some(s) => s.as_str(),
         };
         let p: Paragraph<'_> = Paragraph::new(selected_text).style(style).block(block);
 
@@ -845,9 +845,9 @@ impl MockComponent for KeyCombo {
             }
             Cmd::Cancel => {
                 self.states.cancel_tab();
-                let prev_input = self.states_input.input.clone();
+                let prev_len = self.states_input.input.len();
                 self.states_input.delete();
-                if prev_input == self.states_input.input {
+                if prev_len == self.states_input.input.len() {
                     CmdResult::None
                 } else {
                     CmdResult::Changed(self.state())
@@ -866,9 +866,9 @@ impl MockComponent for KeyCombo {
 
             Cmd::Delete => {
                 // Backspace and None
-                let prev_input = self.states_input.input.clone();
+                let prev_len = self.states_input.input.len();
                 self.states_input.backspace();
-                if prev_input == self.states_input.input {
+                if prev_len == self.states_input.input.len() {
                     CmdResult::None
                 } else {
                     CmdResult::Changed(self.state())
@@ -892,10 +892,10 @@ impl MockComponent for KeyCombo {
             }
             Cmd::Type(ch) => {
                 // Push char to input
-                let prev_input = self.states_input.input.clone();
+                let prev_len = self.states_input.input.len();
                 self.states_input.append(ch, self.get_input_len());
                 // Message on change
-                if prev_input == self.states_input.input {
+                if prev_len == self.states_input.input.len() {
                     CmdResult::None
                 } else {
                     CmdResult::Changed(self.state())

tui/src/ui/components/config_editor/update.rs

@@ -350,16 +350,13 @@ impl Model {
 
                 match id {
                     IdConfigEditor::LibraryHighlightSymbol => {
-                        self.config_editor.theme.style.library.highlight_symbol =
-                            symbol.to_string();
+                        self.config_editor.theme.style.library.highlight_symbol = symbol;
                     }
                     IdConfigEditor::PlaylistHighlightSymbol => {
-                        self.config_editor.theme.style.playlist.highlight_symbol =
-                            symbol.to_string();
+                        self.config_editor.theme.style.playlist.highlight_symbol = symbol;
                     }
                     IdConfigEditor::CurrentlyPlayingTrackSymbol => {
-                        self.config_editor.theme.style.playlist.current_track_symbol =
-                            symbol.to_string();
+                        self.config_editor.theme.style.playlist.current_track_symbol = symbol;
                     }
                     _ => {}
                 };

tui/src/ui/components/lyric.rs

@@ -130,8 +130,7 @@ impl Model {
             )
             .is_ok());
         self.lyric_update_title();
-        let lyric_line = self.lyric_line.clone();
-        self.lyric_set_lyric(&lyric_line);
+        self.lyric_set_lyric(self.lyric_line.clone());
     }
 
     pub fn lyric_update_for_podcast_by_current_track(&mut self) {

tui/src/ui/components/music_library.rs

@@ -342,7 +342,7 @@ impl Model {
                 .mount(
                     Id::Library,
                     Box::new(MusicLibrary::new(
-                        &self.library.tree.clone(),
+                        &self.library.tree,
                         current_node,
                         self.config_tui.clone(),
                     ),),
@@ -358,7 +358,7 @@ impl Model {
             .remount(
                 Id::Library,
                 Box::new(MusicLibrary::new(
-                    &self.library.tree.clone(),
+                    &self.library.tree,
                     current_node,
                     self.config_tui.clone(),
                 ),),
@@ -473,7 +473,7 @@ impl Model {
         let root = self.library.tree.root();
         let p: &Path = Path::new(root.id());
         let all_items = walkdir::WalkDir::new(p).follow_links(true);
-        let mut idx = 0;
+        let mut idx: usize = 0;
         let search = format!("*{}*", input.to_lowercase());
         let search = wildmatch::WildMatch::new(&search);
         for record in all_items.into_iter().filter_map(std::result::Result::ok) {

tui/src/ui/components/podcast.rs

@@ -427,7 +427,7 @@ impl Model {
         });
     }
 
-    pub fn podcast_add(&mut self, url: &str) {
+    pub fn podcast_add(&mut self, url: String) {
         let feed = PodcastFeed::new(None, url, None);
 
         crate::podcast::check_feed(
@@ -627,7 +627,7 @@ impl Model {
                     .ok_or_else(|| anyhow!("get podcast selected failed."))?;
                 let pcf = PodcastFeed::new(
                     Some(pod_selected.id),
-                    &pod_selected.url.clone(),
+                    pod_selected.url.clone(),
                     Some(pod_selected.title.clone()),
                 );
                 pod_data.push(pcf);
@@ -640,7 +640,7 @@ impl Model {
                     .podcasts
                     .iter()
                     .map(|pod| {
-                        PodcastFeed::new(Some(pod.id), &pod.url.clone(), Some(pod.title.clone()))
+                        PodcastFeed::new(Some(pod.id), pod.url.clone(), Some(pod.title.clone()))
                     })
                     .collect();
             }
@@ -843,7 +843,7 @@ impl Model {
 
             for ep in &mut podcast_selected.episodes {
                 if ep.path.is_some() {
-                    match std::fs::remove_file(ep.path.clone().unwrap()) {
+                    match std::fs::remove_file(ep.path.as_ref().unwrap()) {
                         Ok(()) => {
                             eps_to_remove.push(ep.id);
                             ep.path = None;
@@ -977,12 +977,11 @@ impl Model {
 
     pub fn podcast_update_search_episode(&mut self, input: &str) {
         let mut table: TableBuilder = TableBuilder::default();
-        let mut idx = 0;
+        let mut idx: usize = 0;
         let search = format!("*{}*", input.to_lowercase());
         let mut db_tracks = vec![];
         // Get all episodes
-        let podcasts = self.podcast.podcasts.clone();
-        for podcast in podcasts {
+        for podcast in &self.podcast.podcasts {
             if let Ok(episodes) = self.podcast.db_podcast.get_episodes(podcast.id, true) {
                 db_tracks.extend(episodes);
             }
@@ -998,11 +997,11 @@ impl Model {
                     if idx > 0 {
                         table.add_row();
                     }
+                    idx += 1;
                     table
                         .add_col(TextSpan::new(idx.to_string()))
                         .add_col(TextSpan::new(record.title).bold())
                         .add_col(TextSpan::new(format!("{}", record.id)));
-                    idx += 1;
                 }
             }
         }
@@ -1013,10 +1012,10 @@ impl Model {
 
     pub fn podcast_update_search_podcast(&mut self, input: &str) {
         let mut table: TableBuilder = TableBuilder::default();
-        let mut idx = 0;
+        let mut idx: usize = 0;
         let search = format!("*{}*", input.to_lowercase());
         // Get all episodes
-        let db_tracks = self.podcast.podcasts.clone();
+        let db_tracks = &self.podcast.podcasts;
 
         if db_tracks.is_empty() {
             table.add_col(TextSpan::from("0"));
@@ -1028,11 +1027,11 @@ impl Model {
                     if idx > 0 {
                         table.add_row();
                     }
+                    idx += 1;
                     table
                         .add_col(TextSpan::new(idx.to_string()))
-                        .add_col(TextSpan::new(record.title).bold())
+                        .add_col(TextSpan::new(&record.title).bold())
                         .add_col(TextSpan::new(format!("{}", record.id)));
-                    idx += 1;
                 }
             }
         }

tui/src/ui/components/popups/message.rs

@@ -56,8 +56,8 @@ impl Model {
         if let Ok(Some(AttrValue::Payload(PropPayload::Vec(spans)))) =
             self.app.query(&Id::MessagePopup, Attribute::Text)
         {
-            if let Some(display_text) = spans.first() {
-                let d = display_text.clone().unwrap_text_span().content;
+            if let Some(display_text) = spans.into_iter().next() {
+                let d = display_text.unwrap_text_span().content;
                 if text.eq(&d) {
                     self.app.umount(&Id::MessagePopup).ok();
                 }

tui/src/ui/components/popups/podcast.rs

@@ -277,13 +277,15 @@ impl Model {
 
     pub fn update_podcast_search_table(&mut self) {
         let mut table: TableBuilder = TableBuilder::default();
-        let mut idx = 0;
+        let mut idx: usize = 0;
         if let Some(vec) = &self.podcast.search_results {
             for record in vec {
                 if idx > 0 {
                     table.add_row();
                 }
 
+                idx += 1;
+
                 let title = record
                     .title
                     .clone()
@@ -293,7 +295,6 @@ impl Model {
                     .add_col(TextSpan::new(title).bold())
                     .add_col(TextSpan::new(record.url.clone()));
                 // .add_col(TextSpan::new(record.album().unwrap_or("Unknown Album")));
-                idx += 1;
             }
             // if self.player.playlist.is_empty() {
             //     table.add_col(TextSpan::from("0"));

tui/src/ui/model/download_tracker.rs

@@ -18,8 +18,8 @@ impl Default for DownloadTracker {
 
 #[allow(dead_code)]
 impl DownloadTracker {
-    pub fn increase_one(&mut self, url: &str) {
-        self.items.insert(url.to_string());
+    pub fn increase_one<U: Into<String>>(&mut self, url: U) {
+        self.items.insert(url.into());
     }
 
     pub fn decrease_one(&mut self, url: &str) {