-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less clones & consistent search result indexes #441
Merged
Merged
+78
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary also mark it "const"
…of reference to reduce clones necessary
as "PodcastFeed" already contains it
because the rest is discarded anyway
…chars): get slice, not a cloned vec
…ng in render logic
…ning in last usage
…hter change checking because either a append, delete or noop will happen, never a replace. So the length will either be longer, shorter or nothing changed.
also force idx to be usize, otherwise early wrap might occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on doing less clones, but also does some other slight fixes that would be annoying to put in their separate PRs:
1
i32
for some reason)context
withwith_context
)PCMsg::Error
to not have a duplicateurl
(String) asfeed
already contains it