Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of notary-server using GH Actions & AWS CodeDeploy #419

Merged
merged 16 commits into from
Jan 30, 2024
Merged

Deployment of notary-server using GH Actions & AWS CodeDeploy #419

merged 16 commits into from
Jan 30, 2024

Conversation

ntampakas
Copy link
Collaborator

This PR introduces automatic deployment of notary-server binary to a dedicated AWS EC2 instance using GH Actions Workflow and triggering AWS CodeDeploy with temporary security credentials in IAM.

  • The cargo build step is executed on a GH runner to avoid computational needs on our server and potential disruptions. This approach also helps to decrease app downtime.
  • The new binary is uploaded to an S3 bucket, and when CodeDeploy is triggered it:
    • checkouts the selected branch
    • retrieves the binary from the S3 bucket
    • copies it to the appropriate directory
    • restarts the process.

Additionally, a log file has been introduced under the tlsn directory and the workflow supports nightly and stable versions deployment.

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
I have added some comments and questions

Co-authored-by: Hendrik Eeckhaut <[email protected]>
@yuroitaki yuroitaki self-requested a review January 26, 2024 05:14
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Got a few comments, though most are just cosmetic

@yuroitaki yuroitaki self-requested a review January 30, 2024 16:56
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much again for your help @ntampakas !

@yuroitaki yuroitaki merged commit b984b07 into tlsnotary:dev Jan 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants