Deployment of multiple stable versions #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
reviewed
Mar 20, 2024
yuroitaki
requested changes
Mar 20, 2024
|
Ah i guess one more question, in this setup ec2 instance tag is heavily used to pass the right version and port around, will there be any risk of these values being mistakenly modified by anyone on the AWS website? Was wondering if there is a safer place to store them, but if you or your team deem it's pretty low risk or there isn't better options, then I am totally fine with ec2 tag :) |
yuroitaki
reviewed
Mar 21, 2024
yuroitaki
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks a lot for answering all my queries and addressing all my concerns, great work! @ntampakas
sinui0
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Remove cargo/bin from PATH * Modify script to run only in nightly env * Modify script to stop the oldest version in stable env * Modify script to support dir preparation for the 3 latest stable versions * Modify script to start service for the 3 latest stable versions * Modify sercice validation script * Create proxy modification script * Add step in workflow to enable ssm execution against proxy + aux script * Add running state filter when fetching InstanceID * Enhancement of validation script * Modify bash behavior * Point tags/deployment to new AWS resources * Change GH owner to production one * Point tags to new EC2 v1 * Move all cd scripts to a new folder * Add comment * Add comment * Add comment * Add comment * Modify scripts to support exit on error * Check if all stable ports are in use and terminate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an enhancement of #419 and introduces the capability of running the three latest stable versions simultaneously on the system.
The requirement was to have all these versions deployed under the same EC2 instance.
The user can access a specific version, by adding it as a path at the end of notary URL. F.x.:
https://notary.pse.dev/v0.1.0-alpha.1 or https://notary.pse.dev/v0.1.0-alpha.2, etc.
The deployment of the backend, is (still) being accomplished using AWS CodeDeploy. To keep the complexity of the appspec-scripts as simple as possible, it was decided to trigger the proxy using AWS SSM.
A new step was added to the workflow as well, which is executed only when a stable deployment is triggered. Its purpose is to make the appropriated changes to the proxy server, using the method stated above.
Additionally, some minor enhancements were applied, such as adding more filters when querying AWS resources, removing unused PATH, and changing shell options values.