-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Install a fresh python virtual env every time (Linux) #10797
Conversation
⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future. Non-collaborators requested: Attn Admins: Admin Instructions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll preface with the fact I have no problem with this (and my approval of the PR shows that too); however, I just want to understand the problem a little more. What is the use case in which upgrading/installing dependencies is failing? Are there CI pipelines in which this is happening, or is this internal usage of the edk2 container? If so what's the different use case that it's failing there then here?
It is to unblock #10795. Issue was originally filed in the container repo but that was just to track the issue with the container it appears in. The solution here in edk2 is fine to me because outside the pipeline local users should be running as root in the container and/or can set up their own virtual env. |
Install a fresh python virtual environment every time to ensure correct permissions and compatibility of the packages. This is more robust than relying on being able to upgrade an existing one. Signed-off-by: Oliver Steffen <[email protected]>
f30ee73
to
2201574
Compare
Description
Install a fresh python virtual environment every time to ensure
correct permissions and compatibility of the packages.
This is more robust than relying on being able to upgrade
an existing one.
pip upgrades are currently failing due to incorrect file permissions
in the container image virtual environment.
Let's not make use of the venv in the container and set up a fresh one
each time.
How This Was Tested
Test CI runs, for example #10796
Integration Instructions
--