rpcgen: follow the CPP and RPCGEN_CPP enviromental variables #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
changed the title
cpp may be target prefixed and it may cause issues in other programs if CPP is set
13 tasks
thkukuk
requested changes
Oct 31, 2022
Comment on lines
+351
to
+356
| if ((CPP = getenv("RPCGEN_CPP")) != NULL) | ||
| return; | ||
|
|
||
| if ((CPP = getenv("CPP")) != NULL) | ||
| return; | ||
|
|
There was a problem hiding this comment.
Like with the user provided cpp path (via -Y argument) some lines above, it should be checked that the environment variable is correct and cpp exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp may be target prefixed
and it may cause issues in other programs if CPP is set