Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcsvc-proto: pull patch to follow RPCGEN_CPP env var and replace fal… #190949

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 12, 2022

…lback cpp

setting RPCGEN_CPP is to fix the build of host != build rpcsvc-proto because buildPackages.rpcsvc-proto is used

to fix usage in cross-compilation

thkukuk/rpcsvc-proto#14

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

…lback cpp

setting RPCGEN_CPP is to fix the build of host != build rpcsvc-proto
because buildPackages.rpcsvc-proto is used

to fix usage in cross-compilation
@Artturin Artturin merged commit 9608ace into NixOS:master Sep 13, 2022
@Artturin Artturin deleted the rpcsvcproto-cpp branch September 13, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants