Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] mark doc directories as safe for git to use #516

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[docker] mark doc directories as safe for git to use #516

merged 2 commits into from
Jan 24, 2025

Conversation

shish
Copy link
Collaborator

@shish shish commented Jan 23, 2025

docker mounting can cause the doc directory to be owned by a different user to the one running inside the container, which git complains about, but is fine for our use-case

Stack created with Sapling. Best reviewed with ReviewStack.

shish added 2 commits January 19, 2025 23:46
If the build fails, don't then attempt to run the container-which-wasn't-built
docker mounting can cause the doc directory to be owned by a different user to the one running inside the container, which git complains about, but is fine for our use-case
@shish shish merged commit 7003543 into master Jan 24, 2025
8 of 12 checks passed
@shish shish deleted the pr516 branch January 24, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant