Generate files for multiple versions #503
Draft
+216,031
−40,587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI looks unhappy because of redeclaration, probaly caused by files pending for clean up? I think we may split this huge PR into several small PR (one for generating scripts, and one for each PHP version), which makes the PR easy to read & review. |
This was referenced Jan 23, 2025
shish
changed the title
shish
force-pushed
the
pr503
branch
6 times, most recently
from
cfa3246 to
0d40a34
Compare
tl;dr:
replace
```php
$function_list = read_docs();
generate_files($function_list, "../generated/");
```
with
```php
foreach(["8.1", "8.2", "8.3", "8.4"] as $version) {
exec("cd docs && git checkout $version");
$function_list = read_docs();
generate_files($function_list, "../generated/$version/");
}
```
generate a bunch of stubs like generated/misc.php:
```php
<?php
if(PHP_VERSION == "8.1") require_once __DIR__ . "/8.1/misc.php";
if(PHP_VERSION == "8.2") require_once __DIR__ . "/8.2/misc.php";
if(PHP_VERSION == "8.3") require_once __DIR__ . "/8.3/misc.php";
if(PHP_VERSION == "8.4") require_once __DIR__ . "/8.4/misc.php";
```
This also automates generation of "deprecated" `safe` functions (ie, instead of hard-coding `deprecated/apache.php`, any functions which were generated in `8.1/apache.php` but are no longer needed and thus not-generated in `8.2/apache.php` will end up in `8.2/deprecated.php`. Perhaps it'd be better to put them at the tail of `8.2/apache.php`? PRs welcome)
Currently the `Exceptions` are shared between all versions, which I _think_ is a good idea? (Thoughts, anybody?)
This isn't even remotely tested, just a proof of concept to show what this kind of approach might look like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr:
replace
with
generate a bunch of stubs like generated/misc.php:
This also automates generation of "deprecated"
safefunctions (ie, instead of hard-codingdeprecated/apache.php, any functions which were generated in8.1/apache.phpbut are no longer needed and thus not-generated in8.2/apache.phpwill end up in8.2/deprecated.php. Perhaps it'd be better to put them at the tail of8.2/apache.php? PRs welcome)Currently the
Exceptionsare shared between all versions, which I think is a good idea? (Thoughts, anybody?)This isn't even remotely tested, just a proof of concept to show what this kind of approach might look like