-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] manage pipeline console plugin deployment on openshift #1895
Conversation
deb31e6
to
6620a45
Compare
6620a45
to
e1fb197
Compare
e1fb197
to
bdc8501
Compare
bdc8501
to
57664b9
Compare
57664b9
to
7b86aa9
Compare
I understand that today the plugin depends on |
7b86aa9
to
03aec95
Compare
moved the code base to |
03aec95
to
ab9166f
Compare
pkg/reconciler/openshift/tektonconfig/manifests_post_reconciler.go
Outdated
Show resolved
Hide resolved
ab9166f
to
f5a3859
Compare
f5a3859
to
5ae875c
Compare
return func(u *unstructured.Unstructured) error { | ||
// update metadata.namespace for all the resources | ||
// this change will be updated in cluster wide resource too | ||
// there is no effect on updating namespace on cluster wide resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is the right thing, but ok
ee0b5b5
to
1693b8f
Compare
The following is the coverage report on the affected files.
|
@@ -236,6 +236,15 @@ image-substitutions: | |||
envKeys: | |||
- IMAGE_ADDONS_PARAM_MAVEN_IMAGE | |||
|
|||
# pipelines console plugin image | |||
- image: ghcr.io/openshift-pipelines/console-plugin:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets create an issue, this image needs to be renamed with redhat offical image url
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdemeester Let's give it an lgtm and get it merge.
...penshift/operator/kodata/static/tekton-config/00-console-plugin/pipeline_console_plugin.yaml
Outdated
Show resolved
Hide resolved
pkg/reconciler/openshift/tektonconfig/testdata/postreconcile_manifest/test_post_manifest.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeeva Kandasamy <[email protected]>
1693b8f
to
247e458
Compare
The following is the coverage report on the affected files.
|
/lgtm 👍 |
/lgtm |
Changes
NOTE: This feature is applicable only to OpenShift environment
Implementation description:
cmd/openshift/operator/kodata/static/tekton-config/00-postreconcile/pipeline_console_plugin.yaml
tekton-config
under openshiftconsole.openshift.io
permission to manageConsolePlugin
console.openshift.io/plugins: '["pipeline-console-plugin"]'
added on openshift csv, this will manage entry onConsole
resource, when we deploy the operator via Operator Hub.After deployed, To enable the pipeline console plugin manually, add an entry on
Console
resource.To know more about console plugin visit: https://github.com/openshift/enhancements/blob/master/enhancements/console/dynamic-plugins.md
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes