Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenShift PostReconcile Extension for Results Route RBAC #1947

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add OpenShift PostReconcile Extension for Results Route RBAC #1947

merged 1 commit into from
Feb 8, 2024

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jan 23, 2024 •
edited by jkandasa
Loading

Enables system:authenticated user to view route to Tekton Results API.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

system:authenticated user can view route for Tekton Results API endpoints.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2024
khrm
khrm commented Jan 23, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 57.9% 55.0% -2.9

@khrm khrm force-pushed the resultsRouteView branch from 9e17c95 to 40d03e0 Compare January 31, 2024 04:14
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 57.9% 55.0% -2.9

@khrm khrm force-pushed the resultsRouteView branch from 40d03e0 to 8b77d35 Compare February 5, 2024 05:17
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 57.9% 55.0% -2.9

@khrm khrm force-pushed the resultsRouteView branch from 8b77d35 to c7a9d49 Compare February 5, 2024 05:34
@khrm
Copy link
Contributor Author

khrm commented Feb 5, 2024

/test pull-tekton-operator-unit-tests

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 57.9% 60.0% 2.1

jkandasa
jkandasa approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm still the unit test is missing

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@khrm khrm force-pushed the resultsRouteView branch from c7a9d49 to a43a7ba Compare February 7, 2024 18:49
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@khrm
Copy link
Contributor Author

khrm commented Feb 7, 2024

Added test

@khrm
Copy link
Contributor Author

khrm commented Feb 7, 2024

/test pull-tekton-operator-unit-tests

@khrm
Copy link
Contributor Author

khrm commented Feb 7, 2024

Seems, I need to rebase.

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 60.0% 61.9% 1.9
pkg/reconciler/openshift/tektonresult/extension.go Do not exist 13.2%

@khrm khrm force-pushed the resultsRouteView branch from 00fc2aa to 6018612 Compare February 7, 2024 19:02
@khrm
Add OpenShift Extension for Results Route RBAC
515694e 
Enables system:authenticated user to view route to Tekton Results
API.
@khrm khrm force-pushed the resultsRouteView branch from 6018612 to 515694e Compare February 7, 2024 19:05
@khrm
Copy link
Contributor Author

khrm commented Feb 7, 2024

/test pull-tekton-operator-integration-tests

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonresult_lifecycle.go 60.0% 61.9% 1.9
pkg/reconciler/openshift/tektonresult/extension.go Do not exist 12.2%

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@tekton-robot tekton-robot merged commit 14ade8e into tektoncd:main Feb 8, 2024
8 checks passed
@khrm khrm mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@jkandasa jkandasa jkandasa approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @piyush-garg @jkandasa