Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6-3.7, Django 3.2-4.1 #69

Merged
merged 9 commits into from
Feb 15, 2025
Merged

Drop support for Python 3.6-3.7, Django 3.2-4.1 #69

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ed8b21d
Update docker compose command
browniebroke Feb 14, 2025
afc4328
Drop support for Python 3.6 - 3.8
browniebroke Feb 14, 2025
9ff3b33
docker-compose.yml: the attribute `version` is obsolete, it will be i…
browniebroke Feb 14, 2025
8049174
Restore Python 3.8 and Drop Django 3.2 - 4.1
browniebroke Feb 15, 2025
7e7912c
Remove branch with djange-upgrade
browniebroke Feb 15, 2025
f530791
Remove branches for unsupported Django versions and update method sig…
browniebroke Feb 15, 2025
dee9fa9
Update CHANGES.md
browniebroke Feb 15, 2025
6ab90bf
Remove unused imports and variables
browniebroke Feb 15, 2025
e17883f
Bump package version in __init__.py
browniebroke Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 21 additions & 43 deletions django_zero_downtime_migrations/backends/postgres/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,49 +955,27 @@ def _patched_iter_column_sql(
):
yield self.connection.ops.tablespace_sql(tablespace, inline=True)

if django.VERSION >= (4, 1):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was automatable with django-upgrade, unlike the other branches where the version is specified as django.VERSION[:2]

probably one to keep in mind for the future where adding these kind of branches: https://github.com/adamchainz/django-upgrade?tab=readme-ov-file#versioned-blocks

def _iter_column_sql(
self, column_db_type, params, model, field, field_db_params, include_default
):
if not include_default:
yield from super()._iter_column_sql(
column_db_type,
params,
model,
field,
field_db_params,
include_default,
)
else:
yield from self._patched_iter_column_sql(
column_db_type,
params,
model,
field,
field_db_params,
include_default,
)
else:
def _iter_column_sql(
self, column_db_type, params, model, field, include_default
):
if not include_default:
yield from super()._iter_column_sql(
column_db_type,
params,
model,
field,
include_default,
)
else:
yield from self._patched_iter_column_sql(
column_db_type,
params,
model,
field,
{},
include_default,
)
def _iter_column_sql(
self, column_db_type, params, model, field, field_db_params, include_default
):
if not include_default:
yield from super()._iter_column_sql(
column_db_type,
params,
model,
field,
field_db_params,
include_default,
)
else:
yield from self._patched_iter_column_sql(
column_db_type,
params,
model,
field,
field_db_params,
include_default,
)

def _alter_column_set_not_null(self, model, new_field):
self.deferred_sql.append(self._sql_column_not_null % {
Expand Down