Drop support for Python 3.6-3.7, Django 3.2-4.1 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnored, please remove it to avoid potential confusion
tbicr
requested changes
Feb 15, 2025
tox.ini
Outdated
| py{3.6,3.7,3.8,3.9,3.10}-django{3.2} | ||
| py{3.9,3.10,3.11,3.12}-django{4.2}-psycopg{2,3} | ||
| py{3.9,3.10,3.11}-django{4.0,4.1} | ||
| py{3.9,3.10}-django{3.2} |
There was a problem hiding this comment.
can we:
- remove django 3.2 with python 3.6-3.7
- will require
django.VERSION[:2] <= (3, 2)branch removal
- will require
- remove django 4.0 and django 4.1
- will require
django.VERSION[:2] < (4, 0)anddjango.VERSION[:2] >= (4, 0)branch removal - will require
django.VERSION[:2] < (4, 1)anddjango.VERSION[:2] >= (4, 1)branch removal - will require
django.VERSION[:2] < (4, 2)anddjango.VERSION[:2] >= (4, 2)branch removal - will require
# TODO: after django 4.1 support drop replace *args, **kwargs with original signaturecomment removal and signature fix
- will require
- keep django 4.2 and keep python 3.8, ie. postpone python 3.8 removal with django 4.2 removal or when it will became blocker
Run 'django-upgrade --target-version 4.2 `find ./django_zero_downtime_migrations -name "*.py"`'
browniebroke
force-pushed
the
drop/python-3.6-3.8-support
branch
from
b187220 to
dee9fa9
Compare
To 0.17 I assume? |
browniebroke
commented
Feb 15, 2025
| @@ -955,49 +955,27 @@ def _patched_iter_column_sql( | |||
| ): | |||
| yield self.connection.ops.tablespace_sql(tablespace, inline=True) | |||
|
|
|||
| if django.VERSION >= (4, 1): | |||
There was a problem hiding this comment.
This one was automatable with django-upgrade, unlike the other branches where the version is specified as django.VERSION[:2]
probably one to keep in mind for the future where adding these kind of branches: https://github.com/adamchainz/django-upgrade?tab=readme-ov-file#versioned-blocks
browniebroke
changed the title
tbicr
approved these changes
Feb 15, 2025
browniebroke
commented
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47
They're all EOL:
https://endoflife.date/python