Upgrade go pulsar client 0.14 and go version 1.21 #136
+80
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klevy-toast
commented
Jan 9, 2025
| @@ -131,8 +131,9 @@ func testTenantImported() resource.ImportStateCheckFunc { | |||
| } | |||
| } | |||
|
|
|||
| func testPulsarTenantExists(tenant string) resource.TestCheckFunc { | |||
| func testPulsarTenantExists() resource.TestCheckFunc { | |||
There was a problem hiding this comment.
This change is necessitated by the unparam linter..
freeznet
approved these changes
Jan 10, 2025
maxsxu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #135
Motivation
I am attempting to implement a feature that requires a newer client version.
Modifications
Upgrading to the latest version of the Go Pulsar Client 0.14.0, which supports minimum Go version 1.21
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)