Upgrade go pulsar client 0.14 and go version 1.21 (#136)

* Upgrade go pulsar client 0.14 and go version 1.21

* Bump golangci-lint to 1.54.1

* Remove deprecated linters and fix unparam linting

.github/CONTRIBUTING.md

@@ -84,5 +84,5 @@ add the license at the beginning of each file. The location of the header file:
 
 ## Update dependencies
 
-The `terraform-provider-pulsar` uses [Go 1.16 module](https://github.com/golang/go/wiki/Modules) to manage dependencies.
+The `terraform-provider-pulsar` uses [Go module](https://go.dev/wiki/Modules) to manage dependencies.
 To add or update a dependency, use the `go mod edit` command to change the dependencies

.github/workflows/acctest.yaml

@@ -30,7 +30,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.18
+          go-version: 1.21
         id: go
 
       - name: Setup Terraform

.github/workflows/linter.yml

@@ -30,13 +30,13 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.18
+          go-version: 1.21
         id: go
 
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.46.2
+          version: v1.54.1
 
   goreleaser:
     name: Run GoReleaser check

.golangci.yaml

@@ -5,20 +5,17 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - deadcode
     - gocritic
     - goimports
     - gosimple
     - govet
     - ineffassign
     - misspell
     - staticcheck
-    - structcheck
     - stylecheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
     - lll
     - prealloc

Makefile

@@ -97,7 +97,7 @@ lint:
 
 tools:
 	go install github.com/bflad/tfproviderlint/cmd/[email protected]
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1
 
 test-compile:
 	@if [ "$(TEST)" = "./..." ]; then \

README.md

@@ -25,7 +25,7 @@ a [Terraform](https://www.terraform.io) provider for managing [Apache Pulsar](ht
 # Prerequisites
 
 - [Terraform](https://www.terraform.io/downloads.html) 0.12.0 or later
-- [Go](https://golang.org/doc/install) 1.16 or later (to build the provider plugin)
+- [Go](https://golang.org/doc/install) 1.21 or later (to build the provider plugin)
 
 # Installation
 

go.mod

@@ -1,15 +1,15 @@
 module github.com/streamnative/terraform-provider-pulsar
 
-go 1.18
+go 1.21
 
 require (
-	github.com/apache/pulsar-client-go v0.12.0
-	github.com/cenkalti/backoff/v4 v4.1.2
+	github.com/apache/pulsar-client-go v0.14.0
+	github.com/cenkalti/backoff/v4 v4.2.1
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/terraform-plugin-log v0.4.0
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.16.0
 	github.com/pkg/errors v0.9.1
-	github.com/stretchr/testify v1.8.0
+	github.com/stretchr/testify v1.9.0
 )
 
 require (
@@ -23,11 +23,11 @@ require (
 	github.com/dvsekhvalnov/jose2go v1.6.0 // indirect
 	github.com/fatih/color v1.7.0 // indirect
 	github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
-	github.com/golang-jwt/jwt v3.2.1+incompatible // indirect
-	github.com/golang/protobuf v1.5.3 // indirect
+	github.com/golang-jwt/jwt/v5 v5.2.1 // indirect
+	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/google/go-cmp v0.5.9 // indirect
 	github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
-	github.com/hashicorp/errwrap v1.0.0 // indirect
+	github.com/hashicorp/errwrap v1.1.0 // indirect
 	github.com/hashicorp/go-checkpoint v0.5.0 // indirect
 	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
 	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320 // indirect
@@ -58,16 +58,16 @@ require (
 	github.com/vmihailenco/msgpack/v4 v4.3.12 // indirect
 	github.com/vmihailenco/tagparser v0.1.1 // indirect
 	github.com/zclconf/go-cty v1.10.0 // indirect
-	golang.org/x/crypto v0.17.0 // indirect
-	golang.org/x/net v0.17.0 // indirect
-	golang.org/x/oauth2 v0.7.0 // indirect
-	golang.org/x/sys v0.15.0 // indirect
-	golang.org/x/term v0.15.0 // indirect
+	golang.org/x/crypto v0.22.0 // indirect
+	golang.org/x/net v0.23.0 // indirect
+	golang.org/x/oauth2 v0.11.0 // indirect
+	golang.org/x/sys v0.19.0 // indirect
+	golang.org/x/term v0.19.0 // indirect
 	golang.org/x/text v0.14.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
-	google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect
-	google.golang.org/grpc v1.56.3 // indirect
-	google.golang.org/protobuf v1.30.0 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20231016165738-49dd2c1f3d0b // indirect
+	google.golang.org/grpc v1.59.0 // indirect
+	google.golang.org/protobuf v1.33.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/utils v0.0.0-20241210054802-24370beab758 // indirect
 )