Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(temp): use deleted entity in notifications #1327

Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix(temp): use deleted entity in notifications #1327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f7fbad
fix(temp): use deleted entity in notifications
bobeal Feb 3, 2025
62906d1
chore: add comment explaining the temp solution
bobeal Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ption-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class NotificationService(
notificationTrigger
).bind()
.map {
val filteredEntity = previousAndUpdatedExpandedEntities.second.filterAttributes(
// using the "previous" entity (it is actually the previous only for deleted entity events)
// to be able to send deleted attributes in case of a entityDeleted event
val filteredEntity = previousAndUpdatedExpandedEntities.first.filterAttributes(
it.notification.attributes?.toSet().orEmpty(),
it.datasetId?.toSet().orEmpty()
)
Expand Down
Loading