Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(temp): use deleted entity in notifications #1327

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

bobeal
Copy link
Member

@bobeal bobeal commented Feb 3, 2025

Temporary solution while showChanges is not implemented. It allows to have access to attributes in case of a entityDeleted event. For other events, previous and updated entity are the same.

@github-actions github-actions bot added the fix Something isn't working label Feb 3, 2025
@bobeal bobeal self-assigned this Feb 3, 2025
@bobeal bobeal added the subscription Relates to subscription API label Feb 3, 2025
@thomasBousselin
Copy link
Contributor

thomasBousselin commented Feb 3, 2025

For other events, previous and updated entity are the same.

Strange behavior. but if you double checked this its ok.

Also maybe add comment, to avoid later confusion.

@bobeal
Copy link
Member Author

bobeal commented Feb 3, 2025

For other events, previous and updated entity are the same.

Strange behavior.

Temporary while showChanges is not implemented. At the end, the previous entities will be conveyed with the events and will be used to show changes when asked.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Results

   70 files     70 suites   1m 24s ⏱️
1 148 tests 1 148 ✅ 0 💤 0 ❌
1 187 runs  1 187 ✅ 0 💤 0 ❌

Results for commit 62906d1.

@bobeal bobeal merged commit aaf79ce into develop Feb 3, 2025
11 checks passed
@bobeal bobeal deleted the fix/use-deleted-entity-in-notifications branch February 3, 2025 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Something isn't working subscription Relates to subscription API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants