Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28 Renaming the accounts account_id to id for continuity #41

Merged
2 commits merged into from
Jun 6, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2018

Resolves Issue #28

Tests are passing ✅

@ghost ghost requested a review from rmc3 June 6, 2018 15:29
Copy link
Contributor

@rmc3 rmc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've figured out that the examples we were using to test were wrong, this looks good!

@rmc3
Copy link
Contributor

rmc3 commented Jun 6, 2018

Could you update https://github.com/stelligent/cumulogenesis/blob/master/examples/config/all-features.yaml to reflect this change as well?

@ghost
Copy link
Author

ghost commented Jun 6, 2018

Updated the example as requested. Merging.

@ghost ghost merged commit b1e4790 into master Jun 6, 2018
@ghost ghost deleted the accountid-28 branch June 6, 2018 19:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant