Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename account account_id parameter to id #28

Closed
rmc3 opened this issue May 21, 2018 · 1 comment
Closed

Rename account account_id parameter to id #28

rmc3 opened this issue May 21, 2018 · 1 comment
Labels
backlog enhancement New feature or request MVP

Comments

@rmc3
Copy link
Contributor

rmc3 commented May 21, 2018

To improve consistency with other entity models, the account_id parameter on accounts should be renamed to id.
@rmc3 rmc3 added enhancement New feature or request backlog labels May 21, 2018
@rmc3 rmc3 added the MVP label May 25, 2018
@ghost ghost mentioned this issue Jun 6, 2018
Merged
ghost pushed a commit that referenced this issue Jun 6, 2018
Merge pull request #41 from stelligent/accountid-28
b1e4790 
#28 Renaming the accounts account_id to id for continuity
@rmc3
Copy link
Contributor Author

rmc3 commented Jun 6, 2018

Fixed in #41

@rmc3 rmc3 closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement New feature or request MVP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmc3